diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2018-04-09 14:39:58 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2018-04-09 14:39:58 -0400 |
commit | af1a949109d8212711df943c053b1038c0afdae1 (patch) | |
tree | 3d532e1bcd3ce3dfd1fa7dbb41480e25d342981e /src/backend/storage/file/reinit.c | |
parent | f5543d47bcb2fee2ab69220f51e2078c11e19843 (diff) | |
download | postgresql-af1a949109d8212711df943c053b1038c0afdae1.tar.gz postgresql-af1a949109d8212711df943c053b1038c0afdae1.zip |
Further cleanup of client dependencies on src/include/catalog headers.
In commit 9c0a0de4c, I'd failed to notice that catalog/catalog.h
should also be considered a frontend-unsafe header, because it includes
(and needs) the full form of pg_class.h, not to mention relcache.h.
However, various frontend code was depending on it to get
TABLESPACE_VERSION_DIRECTORY, so refactoring of some sort is called for.
The cleanest answer seems to be to move TABLESPACE_VERSION_DIRECTORY,
as well as the OIDCHARS symbol, to common/relpath.h. Do that, and mop up
inclusions as necessary. (I found that quite a few current users of
catalog/catalog.h don't seem to need it at all anymore, apparently as a
result of the refactorings that created common/relpath.[hc]. And
initdb.c needed it only as a route to pg_class_d.h.)
Discussion: https://postgr.es/m/6629.1523294509@sss.pgh.pa.us
Diffstat (limited to 'src/backend/storage/file/reinit.c')
-rw-r--r-- | src/backend/storage/file/reinit.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/backend/storage/file/reinit.c b/src/backend/storage/file/reinit.c index 7b8a1253c48..74ff6c359b5 100644 --- a/src/backend/storage/file/reinit.c +++ b/src/backend/storage/file/reinit.c @@ -16,7 +16,6 @@ #include <unistd.h> -#include "catalog/catalog.h" #include "common/relpath.h" #include "storage/copydir.h" #include "storage/fd.h" |