diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2006-03-03 00:02:02 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2006-03-03 00:02:02 +0000 |
| commit | 9a506a6257f3874d07cd185bec981f2ad335fc54 (patch) | |
| tree | 0304a9a823f09489a7b0822c026f144e2854de5e /src/backend/storage/buffer/bufmgr.c | |
| parent | f0bfc02001c5f9a78fb3a5f72b97ffb35d526ec6 (diff) | |
| download | postgresql-9a506a6257f3874d07cd185bec981f2ad335fc54.tar.gz postgresql-9a506a6257f3874d07cd185bec981f2ad335fc54.zip | |
Arrange to call AbsorbFsyncRequests every so often while performing a
checkpoint in the bgwriter. This forestalls overflow of the fsync request
queue, which is not fatal but causes considerable performance degradation
when it occurs (because backends then have to do their own fsyncs). Per
patch from Itagaki Takahiro, modified a little bit by me.
Diffstat (limited to 'src/backend/storage/buffer/bufmgr.c')
| -rw-r--r-- | src/backend/storage/buffer/bufmgr.c | 23 |
1 files changed, 21 insertions, 2 deletions
diff --git a/src/backend/storage/buffer/bufmgr.c b/src/backend/storage/buffer/bufmgr.c index 11e83812d0c..41ca4c14495 100644 --- a/src/backend/storage/buffer/bufmgr.c +++ b/src/backend/storage/buffer/bufmgr.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.202 2006/01/06 00:04:20 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/storage/buffer/bufmgr.c,v 1.203 2006/03/03 00:02:01 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -42,6 +42,7 @@ #include "lib/stringinfo.h" #include "miscadmin.h" +#include "postmaster/bgwriter.h" #include "storage/buf_internals.h" #include "storage/bufmgr.h" #include "storage/bufpage.h" @@ -61,6 +62,9 @@ #define LocalBufHdrGetBlock(bufHdr) \ LocalBufferBlockPointers[-((bufHdr)->buf_id + 2)] +/* interval for calling AbsorbFsyncRequests in BufferSync */ +#define WRITES_PER_ABSORB 1000 + /* GUC variables */ bool zero_damaged_pages = false; @@ -892,6 +896,7 @@ BufferSync(void) { int buf_id; int num_to_scan; + int absorb_counter; /* * Find out where to start the circular scan. @@ -905,9 +910,23 @@ BufferSync(void) * Loop over all buffers. */ num_to_scan = NBuffers; + absorb_counter = WRITES_PER_ABSORB; while (num_to_scan-- > 0) { - (void) SyncOneBuffer(buf_id, false); + if (SyncOneBuffer(buf_id, false)) + { + /* + * If in bgwriter, absorb pending fsync requests after each + * WRITES_PER_ABSORB write operations, to prevent overflow of + * the fsync request queue. If not in bgwriter process, this is + * a no-op. + */ + if (--absorb_counter <= 0) + { + AbsorbFsyncRequests(); + absorb_counter = WRITES_PER_ABSORB; + } + } if (++buf_id >= NBuffers) buf_id = 0; } |