diff options
author | David Rowley <drowley@postgresql.org> | 2023-08-02 12:05:41 +1200 |
---|---|---|
committer | David Rowley <drowley@postgresql.org> | 2023-08-02 12:05:41 +1200 |
commit | 3845577cb55eab3e06b3724e307ebbcac31f4841 (patch) | |
tree | a97ee2a4769561c31754648b5d4b4f3a002b8684 /src/backend/replication/logical/tablesync.c | |
parent | 36ab831f9abc6f6b0ab74dd62e0faad75dbf42bf (diff) | |
download | postgresql-3845577cb55eab3e06b3724e307ebbcac31f4841.tar.gz postgresql-3845577cb55eab3e06b3724e307ebbcac31f4841.zip |
Fix performance regression in pg_strtointNN_safe functions
Between 6fcda9aba and 1b6f632a3, the pg_strtoint functions became quite
a bit slower in v16, despite efforts in 6b423ec67 to speed these up.
Since the majority of cases for these functions will only contain
base-10 digits, perhaps prefixed by a '-', it makes sense to have a
special case for this and just fall back on the more complex version
which processes hex, octal, binary and underscores if the fast path
version fails to parse the string.
While we're here, update the header comments for these functions to
mention that hex, octal and binary formats along with underscore
separators are now supported.
Author: Andres Freund, David Rowley
Reported-by: Masahiko Sawada
Reviewed-by: Dean Rasheed, John Naylor
Discussion: https://postgr.es/m/CAD21AoDvDmUQeJtZrau1ovnT_smN940%3DKp6mszNGK3bq9yRN6g%40mail.gmail.com
Backpatch-through: 16, where 6fcda9aba and 1b6f632a3 were added
Diffstat (limited to 'src/backend/replication/logical/tablesync.c')
0 files changed, 0 insertions, 0 deletions