diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2020-03-17 18:18:01 -0300 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2020-03-17 18:18:01 -0300 |
| commit | 5d0c2d5eba6b58b3c9955ee41c917f7df8b62746 (patch) | |
| tree | c246021bf6e93f1e96891ba1a8bdaffdfeefbe76 /src/backend/replication/logical/logicalfuncs.c | |
| parent | bcd1c3630095e48bc3b1eb0fc8e8c8a7c851eba1 (diff) | |
| download | postgresql-5d0c2d5eba6b58b3c9955ee41c917f7df8b62746.tar.gz postgresql-5d0c2d5eba6b58b3c9955ee41c917f7df8b62746.zip | |
Remove logical_read_local_xlog_page
It devolved into a content-less wrapper over read_local_xlog_page, with
nothing to add, plus it's easily confused with walsender's
logical_read_xlog_page. There doesn't seem to be any reason for it to
stay.
src/include/replication/logicalfuncs.h becomes empty, so remove it too.
The prototypes it initially had were absorbed by generated fmgrprotos.h.
Discussion: https://postgr.es/m/20191115214102.GA15616@alvherre.pgsql
Diffstat (limited to 'src/backend/replication/logical/logicalfuncs.c')
| -rw-r--r-- | src/backend/replication/logical/logicalfuncs.c | 11 |
1 files changed, 1 insertions, 10 deletions
diff --git a/src/backend/replication/logical/logicalfuncs.c b/src/backend/replication/logical/logicalfuncs.c index a3a83a9d367..04510094a80 100644 --- a/src/backend/replication/logical/logicalfuncs.c +++ b/src/backend/replication/logical/logicalfuncs.c @@ -28,7 +28,6 @@ #include "nodes/makefuncs.h" #include "replication/decode.h" #include "replication/logical.h" -#include "replication/logicalfuncs.h" #include "replication/message.h" #include "storage/fd.h" #include "utils/array.h" @@ -105,14 +104,6 @@ check_permissions(void) errmsg("must be superuser or replication role to use replication slots"))); } -int -logical_read_local_xlog_page(XLogReaderState *state, XLogRecPtr targetPagePtr, - int reqLen, XLogRecPtr targetRecPtr, char *cur_page) -{ - return read_local_xlog_page(state, targetPagePtr, reqLen, - targetRecPtr, cur_page); -} - /* * Helper function for the various SQL callable logical decoding functions. */ @@ -242,7 +233,7 @@ pg_logical_slot_get_changes_guts(FunctionCallInfo fcinfo, bool confirm, bool bin ctx = CreateDecodingContext(InvalidXLogRecPtr, options, false, - logical_read_local_xlog_page, + read_local_xlog_page, LogicalOutputPrepareWrite, LogicalOutputWrite, NULL); |