diff options
| author | Andres Freund <andres@anarazel.de> | 2014-10-01 13:13:59 +0200 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2014-10-01 13:22:17 +0200 |
| commit | 0ef3c29a4b43e72d93cff65a17a9ccccff87618d (patch) | |
| tree | dd09f894757e2b09e91798669d9c16c96cfbe64d /src/backend/replication/logical/logicalfuncs.c | |
| parent | ef8863844bb0b0dab7b92c5f278302a42b4bf05a (diff) | |
| download | postgresql-0ef3c29a4b43e72d93cff65a17a9ccccff87618d.tar.gz postgresql-0ef3c29a4b43e72d93cff65a17a9ccccff87618d.zip | |
Improve documentation about binary/textual output mode for output plugins.
Also improve related error message as it contributed to the confusion.
Discussion: CAB7nPqQrqFzjqCjxu4GZzTrD9kpj6HMn9G5aOOMwt1WZ8NfqeA@mail.gmail.com,
CAB7nPqQXc_+g95zWnqaa=mVQ4d3BVRs6T41frcEYi2ocUrR3+A@mail.gmail.com
Per discussion between Michael Paquier, Robert Haas and Andres Freund
Backpatch to 9.4 where logical decoding was introduced.
Diffstat (limited to 'src/backend/replication/logical/logicalfuncs.c')
| -rw-r--r-- | src/backend/replication/logical/logicalfuncs.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/replication/logical/logicalfuncs.c b/src/backend/replication/logical/logicalfuncs.c index 9692f98b55e..3a5ec2f61d9 100644 --- a/src/backend/replication/logical/logicalfuncs.c +++ b/src/backend/replication/logical/logicalfuncs.c @@ -401,7 +401,9 @@ pg_logical_slot_get_changes_guts(FunctionCallInfo fcinfo, bool confirm, bool bin ctx->options.output_type != OUTPUT_PLUGIN_TEXTUAL_OUTPUT) ereport(ERROR, (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), - errmsg("output plugin cannot produce binary output"))); + errmsg("logical decoding output plugin \"%s\" produces binary output, but \"%s\" expects textual data", + NameStr(MyReplicationSlot->data.plugin), + format_procedure(fcinfo->flinfo->fn_oid)))); ctx->output_writer_private = p; |