diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2020-11-26 12:30:48 -0300 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2020-11-26 12:30:48 -0300 |
| commit | dcfff74fb16622898a9d1df33e530f477caab095 (patch) | |
| tree | 851a9e6824a4baa42c5355397f57c3196b09f6a5 /src/backend/replication/logical/logical.c | |
| parent | 9fbc3f318d039c3e1e8614c38e40843cf8fcffde (diff) | |
| download | postgresql-dcfff74fb16622898a9d1df33e530f477caab095.tar.gz postgresql-dcfff74fb16622898a9d1df33e530f477caab095.zip | |
Restore lock level to update statusFlags
Reverts 27838981be9d (some comments are kept). Per discussion, it does
not seem safe to relax the lock level used for this; in order for it to
be safe, there would have to be memory barriers between the point we set
the flag and the point we set the trasaction Xid, which perhaps would
not be so bad; but there would also have to be barriers at the readers'
side, which from a performance perspective might be bad.
Now maybe this analysis is wrong and it *is* safe for some reason, but
proof of that is not trivial.
Discussion: https://postgr.es/m/20201118190928.vnztes7c2sldu43a@alap3.anarazel.de
Diffstat (limited to 'src/backend/replication/logical/logical.c')
| -rw-r--r-- | src/backend/replication/logical/logical.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c index 4324e326565..f1f4df7d70f 100644 --- a/src/backend/replication/logical/logical.c +++ b/src/backend/replication/logical/logical.c @@ -181,7 +181,7 @@ StartupDecodingContext(List *output_plugin_options, */ if (!IsTransactionOrTransactionBlock()) { - LWLockAcquire(ProcArrayLock, LW_SHARED); + LWLockAcquire(ProcArrayLock, LW_EXCLUSIVE); MyProc->statusFlags |= PROC_IN_LOGICAL_DECODING; ProcGlobal->statusFlags[MyProc->pgxactoff] = MyProc->statusFlags; LWLockRelease(ProcArrayLock); |