diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2018-08-01 17:39:07 -0400 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2018-08-01 17:47:15 -0400 |
| commit | c40489e449ea08e154cd62fa055785873f7bdac8 (patch) | |
| tree | c97f4789aa534001c9ca479d0a89570066375e87 /src/backend/replication/logical/logical.c | |
| parent | 91bc213d90c5a8f2b2e162d4ecf09b9301027ceb (diff) | |
| download | postgresql-c40489e449ea08e154cd62fa055785873f7bdac8.tar.gz postgresql-c40489e449ea08e154cd62fa055785873f7bdac8.zip | |
Fix logical replication slot initialization
This was broken in commit 9c7d06d60680, which inadvertently gave the
wrong value to fast_forward in one StartupDecodingContext call. Fix by
flipping the value. Add a test for the obvious error, namely trying to
initialize a replication slot with an nonexistent output plugin.
While at it, move the CreateDecodingContext call earlier, so that any
errors are reported before sending the CopyBoth message.
Author: Dave Cramer <davecramer@gmail.com>
Reviewed-by: Andres Freund <andres@anarazel.de>
Discussion: https://postgr.es/m/CADK3HHLVkeRe1v4P02-5hj55H3_yJg3AEtpXyEY5T3wuzO2jSg@mail.gmail.com
Diffstat (limited to 'src/backend/replication/logical/logical.c')
| -rw-r--r-- | src/backend/replication/logical/logical.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/replication/logical/logical.c b/src/backend/replication/logical/logical.c index 3cd4eefb9bf..bb83fc9d42d 100644 --- a/src/backend/replication/logical/logical.c +++ b/src/backend/replication/logical/logical.c @@ -312,7 +312,7 @@ CreateInitDecodingContext(char *plugin, ReplicationSlotSave(); ctx = StartupDecodingContext(NIL, InvalidXLogRecPtr, xmin_horizon, - need_full_snapshot, true, + need_full_snapshot, false, read_page, prepare_write, do_write, update_progress); |