aboutsummaryrefslogtreecommitdiff
path: root/src/backend/parser/parser.c
diff options
context:
space:
mode:
authorNathan Bossart <nathan@postgresql.org>2024-02-26 15:47:13 -0600
committerNathan Bossart <nathan@postgresql.org>2024-02-26 15:47:13 -0600
commit42a1de3013eac394c3a170ce728f0280a62187bd (patch)
treec708f6e852903207ee4f0d090e90c02facea08e9 /src/backend/parser/parser.c
parent5fe08c006c826da4a7f5db2a79327477599edbc6 (diff)
downloadpostgresql-42a1de3013eac394c3a170ce728f0280a62187bd.tar.gz
postgresql-42a1de3013eac394c3a170ce728f0280a62187bd.zip
Add helper functions for dshash tables with string keys.
Presently, string keys are not well-supported for dshash tables. The dshash code always copies key_size bytes into new entries' keys, and dshash.h only provides compare and hash functions that forward to memcmp() and tag_hash(), both of which do not stop at the first NUL. This means that callers must pad string keys so that the data beyond the first NUL does not adversely affect the results of copying, comparing, and hashing the keys. To better support string keys in dshash tables, this commit does a couple things: * A new copy_function field is added to the dshash_parameters struct. This function pointer specifies how the key should be copied into new table entries. For example, we only want to copy up to the first NUL byte for string keys. A dshash_memcpy() helper function is provided and used for all existing in-tree dshash tables without string keys. * A set of helper functions for string keys are provided. These helper functions forward to strcmp(), strcpy(), and string_hash(), all of which ignore data beyond the first NUL. This commit also adjusts the DSM registry's dshash table to use the new helper functions for string keys. Reviewed-by: Andy Fan Discussion: https://postgr.es/m/20240119215941.GA1322079%40nathanxps13
Diffstat (limited to 'src/backend/parser/parser.c')
0 files changed, 0 insertions, 0 deletions