diff options
| author | Robert Haas <rhaas@postgresql.org> | 2010-02-02 18:52:33 +0000 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2010-02-02 18:52:33 +0000 |
| commit | d8db6a6096d1b901f2ad9077148a87cd95fb3e86 (patch) | |
| tree | e3881ace8641de0d61b32952363d9ac395fa7fa3 /src/backend/parser/parse_utilcmd.c | |
| parent | 4d32f6d7bf2e4e2715b1f79b379a7cfcca16993c (diff) | |
| download | postgresql-d8db6a6096d1b901f2ad9077148a87cd95fb3e86.tar.gz postgresql-d8db6a6096d1b901f2ad9077148a87cd95fb3e86.zip | |
Fold FindConversion() into FindConversionByName() and remove ACL check.
All callers of FindConversionByName() already do suitable permissions
checking already apart from this function, but this is not just dead
code removal: the unnecessary permissions check can actually lead to
spurious failures - there's no reason why inability to execute the
underlying function should prohibit renaming the conversion, for example.
(The error messages in these cases were also rather poor:
FindConversion would return InvalidOid, eventually leading to a complaint
that the conversion "did not exist", which was not correct.)
KaiGai Kohei
Diffstat (limited to 'src/backend/parser/parse_utilcmd.c')
0 files changed, 0 insertions, 0 deletions