diff options
| author | Bruce Momjian <bruce@momjian.us> | 2000-06-03 04:41:34 +0000 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2000-06-03 04:41:34 +0000 |
| commit | 2ea370a3ceea5f3a30df709dea08c41c1f19e486 (patch) | |
| tree | 0f5d7feb9c13fde7456f99913154d9bf83ecdce5 /src/backend/parser/parse_relation.c | |
| parent | 58785757dd7083716bd9660134000bed8d383d55 (diff) | |
| download | postgresql-2ea370a3ceea5f3a30df709dea08c41c1f19e486.tar.gz postgresql-2ea370a3ceea5f3a30df709dea08c41c1f19e486.zip | |
New warning code about auto-created range table entries.
Diffstat (limited to 'src/backend/parser/parse_relation.c')
| -rw-r--r-- | src/backend/parser/parse_relation.c | 31 |
1 files changed, 25 insertions, 6 deletions
diff --git a/src/backend/parser/parse_relation.c b/src/backend/parser/parse_relation.c index 4bb65cf27e8..9360c1486c2 100644 --- a/src/backend/parser/parse_relation.c +++ b/src/backend/parser/parse_relation.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.40 2000/04/12 17:15:27 momjian Exp $ + * $Header: /cvsroot/pgsql/src/backend/parser/parse_relation.c,v 1.41 2000/06/03 04:41:32 momjian Exp $ * *------------------------------------------------------------------------- */ @@ -373,11 +373,7 @@ expandAll(ParseState *pstate, char *relname, Attr *ref, int *this_resno) { rte = addRangeTableEntry(pstate, relname, ref, FALSE, FALSE, TRUE); -#ifdef WARN_FROM - elog(NOTICE, "Adding missing FROM-clause entry%s for table %s", - pstate->parentParseState != NULL ? " in subquery" : "", - refname); -#endif + warnAutoRange(pstate, ref->relname); } rel = heap_open(rte->relid, AccessShareLock); @@ -526,3 +522,26 @@ attnumTypeId(Relation rd, int attid) */ return rd->rd_att->attrs[attid - 1]->atttypid; } + +void +warnAutoRange(ParseState *pstate, char *refname) +{ + List *temp; + bool foundInFromCl = false; + + foreach(temp, pstate->p_rtable) + { + RangeTblEntry *rte = lfirst(temp); + + if (rte->inFromCl) + { + foundInFromCl = true; + break; + } + } + if (foundInFromCl) + elog(NOTICE, "Adding missing FROM-clause entry%s for table %s", + pstate->parentParseState != NULL ? " in subquery" : "", + refname); +} + |