diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2000-10-05 19:11:39 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2000-10-05 19:11:39 +0000 |
| commit | 05e3d0ee8666b74f11ffad16f46e372459d6e53e (patch) | |
| tree | b273892bfda60f6bad315e84aaa2e9826e226931 /src/backend/optimizer/prep/preptlist.c | |
| parent | 5292637f52c6db8a22f99177f228273cb69fc510 (diff) | |
| download | postgresql-05e3d0ee8666b74f11ffad16f46e372459d6e53e.tar.gz postgresql-05e3d0ee8666b74f11ffad16f46e372459d6e53e.zip | |
Reimplementation of UNION/INTERSECT/EXCEPT. INTERSECT/EXCEPT now meet the
SQL92 semantics, including support for ALL option. All three can be used
in subqueries and views. DISTINCT and ORDER BY work now in views, too.
This rewrite fixes many problems with cross-datatype UNIONs and INSERT/SELECT
where the SELECT yields different datatypes than the INSERT needs. I did
that by making UNION subqueries and SELECT in INSERT be treated like
subselects-in-FROM, thereby allowing an extra level of targetlist where the
datatype conversions can be inserted safely.
INITDB NEEDED!
Diffstat (limited to 'src/backend/optimizer/prep/preptlist.c')
| -rw-r--r-- | src/backend/optimizer/prep/preptlist.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/src/backend/optimizer/prep/preptlist.c b/src/backend/optimizer/prep/preptlist.c index e3b9803d0ab..822c0c79f05 100644 --- a/src/backend/optimizer/prep/preptlist.c +++ b/src/backend/optimizer/prep/preptlist.c @@ -15,7 +15,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/optimizer/prep/preptlist.c,v 1.38 2000/08/08 15:41:48 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/optimizer/prep/preptlist.c,v 1.39 2000/10/05 19:11:30 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -49,6 +49,17 @@ preprocess_targetlist(List *tlist, Index result_relation, List *range_table) { + /* + * Sanity check: if there is a result relation, it'd better be a + * real relation not a subquery. Else parser or rewriter messed up. + */ + if (result_relation) + { + RangeTblEntry *rte = rt_fetch(result_relation, range_table); + + if (rte->subquery != NULL || rte->relid == InvalidOid) + elog(ERROR, "preprocess_targetlist: subquery cannot be result relation"); + } /* * for heap_formtuple to work, the targetlist must match the exact |