diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2009-09-12 22:12:09 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2009-09-12 22:12:09 +0000 |
| commit | 9bb342811bf6a93a574a648c5848feedbaaef8f2 (patch) | |
| tree | ecc60f3017cc58695c4c96ebf6d11669e3de6900 /src/backend/optimizer/plan/createplan.c | |
| parent | 5f1b32ddf826550d65dd6e84b965b6a98589ad19 (diff) | |
| download | postgresql-9bb342811bf6a93a574a648c5848feedbaaef8f2.tar.gz postgresql-9bb342811bf6a93a574a648c5848feedbaaef8f2.zip | |
Rewrite the planner's handling of materialized plan types so that there is
an explicit model of rescan costs being different from first-time costs.
The costing of Material nodes in particular now has some visible relationship
to the actual runtime behavior, where before it was essentially fantasy.
This also fixes up a couple of places where different materialized plan types
were treated differently for no very good reason (probably just oversights).
A couple of the regression tests are affected, because the planner now chooses
to put the other relation on the inside of a nestloop-with-materialize.
So far as I can see both changes are sane, and the planner is now more
consistently following the expectation that it should prefer to materialize
the smaller of two relations.
Per a recent discussion with Robert Haas.
Diffstat (limited to 'src/backend/optimizer/plan/createplan.c')
| -rw-r--r-- | src/backend/optimizer/plan/createplan.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c index 3f211508a1f..ac9b96229a1 100644 --- a/src/backend/optimizer/plan/createplan.c +++ b/src/backend/optimizer/plan/createplan.c @@ -10,7 +10,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/optimizer/plan/createplan.c,v 1.261 2009/07/17 23:19:34 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/optimizer/plan/createplan.c,v 1.262 2009/09/12 22:12:04 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -3266,6 +3266,7 @@ materialize_finished_plan(Plan *subplan) /* Set cost data */ cost_material(&matpath, + subplan->startup_cost, subplan->total_cost, subplan->plan_rows, subplan->plan_width); |