diff options
author | Robert Haas <rhaas@postgresql.org> | 2016-10-21 09:54:29 -0400 |
---|---|---|
committer | Robert Haas <rhaas@postgresql.org> | 2016-10-21 09:54:29 -0400 |
commit | 7012b132d07c2b4ea15b0b3cb1ea9f3278801d98 (patch) | |
tree | d0a15aedea339d5b74ec63768ff5b2db0abd0c2d /src/backend/optimizer/plan/createplan.c | |
parent | 709e461befa8a4999c4ccdbfc7260ef8092e805c (diff) | |
download | postgresql-7012b132d07c2b4ea15b0b3cb1ea9f3278801d98.tar.gz postgresql-7012b132d07c2b4ea15b0b3cb1ea9f3278801d98.zip |
postgres_fdw: Push down aggregates to remote servers.
Now that the upper planner uses paths, and now that we have proper hooks
to inject paths into the upper planning process, it's possible for
foreign data wrappers to arrange to push aggregates to the remote side
instead of fetching all of the rows and aggregating them locally. This
figures to be a massive win for performance, so teach postgres_fdw to
do it.
Jeevan Chalke and Ashutosh Bapat. Reviewed by Ashutosh Bapat with
additional testing by Prabhat Sahu. Various mostly cosmetic changes
by me.
Diffstat (limited to 'src/backend/optimizer/plan/createplan.c')
-rw-r--r-- | src/backend/optimizer/plan/createplan.c | 11 |
1 files changed, 9 insertions, 2 deletions
diff --git a/src/backend/optimizer/plan/createplan.c b/src/backend/optimizer/plan/createplan.c index 47158f64680..ad496746843 100644 --- a/src/backend/optimizer/plan/createplan.c +++ b/src/backend/optimizer/plan/createplan.c @@ -3243,8 +3243,15 @@ create_foreignscan_plan(PlannerInfo *root, ForeignPath *best_path, /* Copy foreign server OID; likewise, no need to make FDW do this */ scan_plan->fs_server = rel->serverid; - /* Likewise, copy the relids that are represented by this foreign scan */ - scan_plan->fs_relids = best_path->path.parent->relids; + /* + * Likewise, copy the relids that are represented by this foreign scan. An + * upper rel doesn't have relids set, but it covers all the base relations + * participating in the underlying scan, so use root's all_baserels. + */ + if (rel->reloptkind == RELOPT_UPPER_REL) + scan_plan->fs_relids = root->all_baserels; + else + scan_plan->fs_relids = best_path->path.parent->relids; /* * If this is a foreign join, and to make it valid to push down we had to |