diff options
| author | Neil Conway <neilc@samurai.com> | 2006-07-02 05:17:26 +0000 |
|---|---|---|
| committer | Neil Conway <neilc@samurai.com> | 2006-07-02 05:17:26 +0000 |
| commit | 7fb9090ebfd8bc96c00e96a5879a6ee67b1623b0 (patch) | |
| tree | 45ac1ed8cdbbc5884876ae8e6d126dccc76cd110 /src/backend/nodes/equalfuncs.c | |
| parent | 277807bd9eba1645d8dfc9252fa29220c4a83751 (diff) | |
| download | postgresql-7fb9090ebfd8bc96c00e96a5879a6ee67b1623b0.tar.gz postgresql-7fb9090ebfd8bc96c00e96a5879a6ee67b1623b0.zip | |
Do a pass of code review for the ALTER TABLE ADD INHERITS patch. Keep
the read lock we hold on the table's parent relation until commit.
Update equalfuncs.c for the new field in AlterTableCmd. Various
improvements to comments, variable names, and error reporting.
There is room for further improvement here, but this is at least
a step in the right direction.
Diffstat (limited to 'src/backend/nodes/equalfuncs.c')
| -rw-r--r-- | src/backend/nodes/equalfuncs.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/nodes/equalfuncs.c b/src/backend/nodes/equalfuncs.c index 3af0acb10a2..424e546b4b8 100644 --- a/src/backend/nodes/equalfuncs.c +++ b/src/backend/nodes/equalfuncs.c @@ -18,7 +18,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/nodes/equalfuncs.c,v 1.274 2006/07/02 02:23:20 momjian Exp $ + * $PostgreSQL: pgsql/src/backend/nodes/equalfuncs.c,v 1.275 2006/07/02 05:17:26 neilc Exp $ * *------------------------------------------------------------------------- */ @@ -765,6 +765,7 @@ _equalAlterTableCmd(AlterTableCmd *a, AlterTableCmd *b) { COMPARE_SCALAR_FIELD(subtype); COMPARE_STRING_FIELD(name); + COMPARE_NODE_FIELD(parent); COMPARE_NODE_FIELD(def); COMPARE_NODE_FIELD(transform); COMPARE_SCALAR_FIELD(behavior); |