diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2000-07-04 06:11:54 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2000-07-04 06:11:54 +0000 |
| commit | cdeca5f590cc3c336c9c217831d68a2ca7f15265 (patch) | |
| tree | f233f7ae62023950d1c169530b83f705c63ceed0 /src/backend/libpq/be-pqexec.c | |
| parent | 9cf327790d978fc4ec6dba1c7f456e0a7596e4e2 (diff) | |
| download | postgresql-cdeca5f590cc3c336c9c217831d68a2ca7f15265.tar.gz postgresql-cdeca5f590cc3c336c9c217831d68a2ca7f15265.zip | |
Make toast-table creation and deletion work somewhat reliably.
Don't go through pg_exec_query_dest(), but directly to the execution
routines. Also, extend parameter lists so that there's no need to
change the global setting of allowSystemTableMods, a hack that was
certain to cause trouble in the event of any error.
Diffstat (limited to 'src/backend/libpq/be-pqexec.c')
| -rw-r--r-- | src/backend/libpq/be-pqexec.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/src/backend/libpq/be-pqexec.c b/src/backend/libpq/be-pqexec.c index c76889a7a72..6834f513113 100644 --- a/src/backend/libpq/be-pqexec.c +++ b/src/backend/libpq/be-pqexec.c @@ -9,7 +9,7 @@ * * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/libpq/Attic/be-pqexec.c,v 1.33 2000/06/28 03:31:41 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/libpq/Attic/be-pqexec.c,v 1.34 2000/07/04 06:11:37 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -136,7 +136,11 @@ PQexec(char *query) * pg_exec_query_dest will put the query results in a portal which will * end up on the top of the portal stack. * - * XXX memory context manipulation needs thought here. + * XXX memory context manipulation is WRONG here --- the query needs + * to be executed in a context different from CurrentMemoryContext, + * perhaps a freshly created sub-context. If I were expecting that + * this code needs to work again, then I'd fix it. But actually I'm + * planning to rip out this entire module sometime soon... tgl 7/2000. * ---------------- */ pg_exec_query_dest(query, Local, CurrentMemoryContext); |