diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2023-09-18 14:27:47 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2023-09-18 14:28:17 -0400 |
| commit | f73fa5a470b4cf850ad404b63c3e352d179d40b0 (patch) | |
| tree | 868a4546b3877aa2edd5d3e9193cfb31d7e6fd43 /src/backend/lib/binaryheap.c | |
| parent | d726897c571b4269096c2cd13af804d16d089669 (diff) | |
| download | postgresql-f73fa5a470b4cf850ad404b63c3e352d179d40b0.tar.gz postgresql-f73fa5a470b4cf850ad404b63c3e352d179d40b0.zip | |
Don't crash if cursor_to_xmlschema is used on a non-data-returning Portal.
cursor_to_xmlschema() assumed that any Portal must have a tupDesc,
which is not so. Add a defensive check.
It's plausible that this mistake occurred because of the rather
poorly chosen name of the lookup function SPI_cursor_find(),
which in such cases is returning something that isn't very much
like a cursor. Add some documentation to try to forestall future
errors of the same ilk.
Report and patch by Boyu Yang (docs changes by me). Back-patch
to all supported branches.
Discussion: https://postgr.es/m/dd343010-c637-434c-a8cb-418f53bda3b8.yangboyu.yby@alibaba-inc.com
Diffstat (limited to 'src/backend/lib/binaryheap.c')
0 files changed, 0 insertions, 0 deletions