diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2023-04-24 13:01:33 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2023-04-24 13:01:33 -0400 |
| commit | fce3b26e97ca98de054734e2af7d9125661a9b3f (patch) | |
| tree | 39507a1cc4b6aac89f6143b586fc5a2d032fd3fe /src/backend/jit/llvm/llvmjit_expr.c | |
| parent | 5a8366ad75eb70cffa791119b404c897983260c6 (diff) | |
| download | postgresql-fce3b26e97ca98de054734e2af7d9125661a9b3f.tar.gz postgresql-fce3b26e97ca98de054734e2af7d9125661a9b3f.zip | |
Rename ExecAggTransReparent, and improve its documentation.
The name of this function suggests that it ought to reparent R/W
expanded objects to be children of the persistent aggcontext, instead
of copying them. In fact it does no such thing, and if you try to
make it do so you will see multiple regression failures. Rename it
to the less-misleading ExecAggCopyTransValue, and add commentary
about why that attractive-sounding optimization won't work. Also
adjust comments at call sites, some of which were describing logic
that has since been moved into ExecAggCopyTransValue.
Discussion: https://postgr.es/m/3004282.1681930251@sss.pgh.pa.us
Diffstat (limited to 'src/backend/jit/llvm/llvmjit_expr.c')
| -rw-r--r-- | src/backend/jit/llvm/llvmjit_expr.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/jit/llvm/llvmjit_expr.c b/src/backend/jit/llvm/llvmjit_expr.c index daefe66f40a..a1b33d6e6cf 100644 --- a/src/backend/jit/llvm/llvmjit_expr.c +++ b/src/backend/jit/llvm/llvmjit_expr.c @@ -2314,7 +2314,7 @@ llvm_compile_expr(ExprState *state) params[5] = LLVMBuildTrunc(b, v_transnull, TypeParamBool, ""); - v_fn = llvm_pg_func(mod, "ExecAggTransReparent"); + v_fn = llvm_pg_func(mod, "ExecAggCopyTransValue"); v_newval = LLVMBuildCall(b, v_fn, params, lengthof(params), |