aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2013-04-28 00:18:45 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2013-04-28 00:18:45 -0400
commitf8db76e875099e5e49f5cd729a673e84c0b0471b (patch)
tree162e43ab4a10fbeef78201e9adc87c433fe9d197 /src/backend/executor
parent5525e6c40bbda351a19b48317eba0f79aa32e447 (diff)
downloadpostgresql-f8db76e875099e5e49f5cd729a673e84c0b0471b.tar.gz
postgresql-f8db76e875099e5e49f5cd729a673e84c0b0471b.zip
Editorialize a bit on new ProcessUtility() API.
Choose a saner ordering of parameters (adding a new input param after the output params seemed a bit random), update the function's header comment to match reality (cmon folks, is this really that hard?), get rid of useless and sloppily-defined distinction between PROCESS_UTILITY_SUBCOMMAND and PROCESS_UTILITY_GENERATED.
Diffstat (limited to 'src/backend/executor')
-rw-r--r--src/backend/executor/functions.c4
-rw-r--r--src/backend/executor/spi.c4
2 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/executor/functions.c b/src/backend/executor/functions.c
index c908f34cfe4..dbb4805ae2c 100644
--- a/src/backend/executor/functions.c
+++ b/src/backend/executor/functions.c
@@ -831,10 +831,10 @@ postquel_getnext(execution_state *es, SQLFunctionCachePtr fcache)
(Node *) es->qd->plannedstmt :
es->qd->utilitystmt),
fcache->src,
+ PROCESS_UTILITY_QUERY,
es->qd->params,
es->qd->dest,
- NULL,
- PROCESS_UTILITY_QUERY);
+ NULL);
result = true; /* never stops early */
}
else
diff --git a/src/backend/executor/spi.c b/src/backend/executor/spi.c
index de8d59a8cdc..ca0d05d2cc0 100644
--- a/src/backend/executor/spi.c
+++ b/src/backend/executor/spi.c
@@ -2093,10 +2093,10 @@ _SPI_execute_plan(SPIPlanPtr plan, ParamListInfo paramLI,
ProcessUtility(stmt,
plansource->query_string,
+ PROCESS_UTILITY_QUERY,
paramLI,
dest,
- completionTag,
- PROCESS_UTILITY_QUERY);
+ completionTag);
/* Update "processed" if stmt returned tuples */
if (_SPI_current->tuptable)