diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2012-01-02 14:43:45 -0500 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2012-01-02 14:43:45 -0500 |
commit | ac7a5a3f25708c03242edc301ad008236fc36c7e (patch) | |
tree | 79c6cac10152d29a11cdf532fc7fc49660876e91 /src/backend/executor/nodeModifyTable.c | |
parent | a8ab8d0eaa96dbaebb646971f8988a3edc28e52c (diff) | |
download | postgresql-ac7a5a3f25708c03242edc301ad008236fc36c7e.tar.gz postgresql-ac7a5a3f25708c03242edc301ad008236fc36c7e.zip |
Fix coerce_to_target_type for coerce_type's klugy handling of COLLATE.
Because coerce_type recurses into the argument of a CollateExpr,
coerce_to_target_type's longstanding code for detecting whether coerce_type
had actually done anything (to wit, returned a different node than it
passed in) was broken in 9.1. This resulted in unexpected failures in
hide_coercion_node; which was not the latter's fault, since it's critical
that we never call it on anything that wasn't inserted by coerce_type.
(Else we might decide to "hide" a user-written function call.)
Fix by removing and replacing the CollateExpr in coerce_to_target_type
itself. This is all pretty ugly but I don't immediately see a way to make
it nicer.
Per report from Jean-Yves F. Barbier.
Diffstat (limited to 'src/backend/executor/nodeModifyTable.c')
0 files changed, 0 insertions, 0 deletions