diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-04-17 13:41:59 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-04-17 13:41:59 -0400 |
| commit | 3125a5baec1cf6d3aaeb8964bc3b3c49835e0452 (patch) | |
| tree | 917d977ad4a5ef88e43904b810f8fe3582da0f25 /src/backend/executor/nodeModifyTable.c | |
| parent | 4db819ba403901d38c4e4328883412c59061bb58 (diff) | |
| download | postgresql-3125a5baec1cf6d3aaeb8964bc3b3c49835e0452.tar.gz postgresql-3125a5baec1cf6d3aaeb8964bc3b3c49835e0452.zip | |
Fix possible future cache reference leak in ALTER EXTENSION ADD/DROP.
recordExtObjInitPriv and removeExtObjInitPriv were sloppy about
calling ReleaseSysCache. The cases cannot occur given current usage
in ALTER EXTENSION ADD/DROP, since we wouldn't get here for these
relkinds; but it seems wise to clean up better.
In passing, extend test logic in test_pg_dump to exercise the
dropped-column code paths here.
Since the case is unreachable at present, there seems no great
need to back-patch; hence fix HEAD only.
Kyotaro Horiguchi, with test case and comment adjustments by me
Discussion: https://postgr.es/m/20200417.151831.1153577605111650154.horikyota.ntt@gmail.com
Diffstat (limited to 'src/backend/executor/nodeModifyTable.c')
0 files changed, 0 insertions, 0 deletions