aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor/nodeIncrementalSort.c
diff options
context:
space:
mode:
authorPeter Geoghegan <pg@bowt.ie>2020-07-19 09:46:44 -0700
committerPeter Geoghegan <pg@bowt.ie>2020-07-19 09:46:44 -0700
commit46ef520b9566d9eccb095ceafa53e5c305cf80b9 (patch)
tree66fef2009f90c6bf7ad09b70d05798d37afa607e /src/backend/executor/nodeIncrementalSort.c
parent72eab84a565cbc0677bf8907cd4bfaddf064bd64 (diff)
downloadpostgresql-46ef520b9566d9eccb095ceafa53e5c305cf80b9.tar.gz
postgresql-46ef520b9566d9eccb095ceafa53e5c305cf80b9.zip
Mark buffers as defined to Valgrind consistently.
Make PinBuffer() mark buffers as defined to Valgrind unconditionally, including when the buffer header spinlock must be acquired. Failure to handle that case could lead to false positive reports from Valgrind. This theoretically creates a risk that we'll mark buffers defined even when external callers don't end up with a buffer pin. That seems perfectly acceptable, though, since in general we make no guarantees about buffers that are unsafe to access being reliably marked as unsafe. Oversight in commit 1e0dfd16, which added valgrind buffer access instrumentation.
Diffstat (limited to 'src/backend/executor/nodeIncrementalSort.c')
0 files changed, 0 insertions, 0 deletions