aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor/nodeHashjoin.c
diff options
context:
space:
mode:
authorPeter Eisentraut <peter@eisentraut.org>2022-12-08 08:51:38 +0100
committerPeter Eisentraut <peter@eisentraut.org>2022-12-08 08:58:15 +0100
commit07c29ca7fe30839a75d15b43c13b290a59a60ddf (patch)
treeeaae2e70db0e33f4f35f6306cfa7ea0bdfef2715 /src/backend/executor/nodeHashjoin.c
parent2d4f1ba6cfc2f0a977f1c30bda9848041343e248 (diff)
downloadpostgresql-07c29ca7fe30839a75d15b43c13b290a59a60ddf.tar.gz
postgresql-07c29ca7fe30839a75d15b43c13b290a59a60ddf.zip
Remove unnecessary casts
Some code carefully cast all data buffer arguments for BufFileWrite() and BufFileRead() to void *, even though the arguments are already void * (and AFAICT were never anything else). Remove this unnecessary clutter. Discussion: https://www.postgresql.org/message-id/flat/11dda853-bb5b-59ba-a746-e168b1ce4bdb%40enterprisedb.com
Diffstat (limited to 'src/backend/executor/nodeHashjoin.c')
-rw-r--r--src/backend/executor/nodeHashjoin.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/src/backend/executor/nodeHashjoin.c b/src/backend/executor/nodeHashjoin.c
index 2718c2113f5..3e1a997f920 100644
--- a/src/backend/executor/nodeHashjoin.c
+++ b/src/backend/executor/nodeHashjoin.c
@@ -1227,8 +1227,8 @@ ExecHashJoinSaveTuple(MinimalTuple tuple, uint32 hashvalue,
*fileptr = file;
}
- BufFileWrite(file, (void *) &hashvalue, sizeof(uint32));
- BufFileWrite(file, (void *) tuple, tuple->t_len);
+ BufFileWrite(file, &hashvalue, sizeof(uint32));
+ BufFileWrite(file, tuple, tuple->t_len);
}
/*
@@ -1260,7 +1260,7 @@ ExecHashJoinGetSavedTuple(HashJoinState *hjstate,
* we can read them both in one BufFileRead() call without any type
* cheating.
*/
- nread = BufFileRead(file, (void *) header, sizeof(header));
+ nread = BufFileRead(file, header, sizeof(header));
if (nread == 0) /* end of file */
{
ExecClearTuple(tupleSlot);
@@ -1275,7 +1275,7 @@ ExecHashJoinGetSavedTuple(HashJoinState *hjstate,
tuple = (MinimalTuple) palloc(header[1]);
tuple->t_len = header[1];
nread = BufFileRead(file,
- (void *) ((char *) tuple + sizeof(uint32)),
+ ((char *) tuple + sizeof(uint32)),
header[1] - sizeof(uint32));
if (nread != header[1] - sizeof(uint32))
ereport(ERROR,