diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2020-05-16 21:00:05 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2020-05-16 21:00:11 -0400 |
| commit | 3048898e73c75f54bb259323382e0e7f6368cb6f (patch) | |
| tree | 2c2433aa9f5d62acc59a15071ed374e73e8ccd9b /src/backend/executor/nodeHash.c | |
| parent | 2c8dd05d6cbc86b7ad21cfd7010e041bb4c3950b (diff) | |
| download | postgresql-3048898e73c75f54bb259323382e0e7f6368cb6f.tar.gz postgresql-3048898e73c75f54bb259323382e0e7f6368cb6f.zip | |
Mop-up for wait event naming issues.
Synchronize the event names for parallel hash join waits with other
event names, by getting rid of the slashes and dropping "-ing"
suffixes. Rename ClogGroupUpdate to XactGroupUpdate, to match the
new SLRU name. Move the ProcSignalBarrier event to the IPC category;
it doesn't belong under IO.
Also a bit more wordsmithing in the wait event documentation tables.
Discussion: https://postgr.es/m/4505.1589640417@sss.pgh.pa.us
Diffstat (limited to 'src/backend/executor/nodeHash.c')
| -rw-r--r-- | src/backend/executor/nodeHash.c | 22 |
1 files changed, 11 insertions, 11 deletions
diff --git a/src/backend/executor/nodeHash.c b/src/backend/executor/nodeHash.c index 5da13ada726..45b342011fe 100644 --- a/src/backend/executor/nodeHash.c +++ b/src/backend/executor/nodeHash.c @@ -255,7 +255,7 @@ MultiExecParallelHash(HashState *node) * ExecHashTableCreate(), or someone else is doing that. Either * way, wait for everyone to arrive here so we can proceed. */ - BarrierArriveAndWait(build_barrier, WAIT_EVENT_HASH_BUILD_ALLOCATING); + BarrierArriveAndWait(build_barrier, WAIT_EVENT_HASH_BUILD_ALLOCATE); /* Fall through. */ case PHJ_BUILD_HASHING_INNER: @@ -311,7 +311,7 @@ MultiExecParallelHash(HashState *node) * counters. */ if (BarrierArriveAndWait(build_barrier, - WAIT_EVENT_HASH_BUILD_HASHING_INNER)) + WAIT_EVENT_HASH_BUILD_HASH_INNER)) { /* * Elect one backend to disable any further growth. Batches @@ -603,7 +603,7 @@ ExecHashTableCreate(HashState *state, List *hashOperators, List *hashCollations, * backend will be elected to do that now if necessary. */ if (BarrierPhase(build_barrier) == PHJ_BUILD_ELECTING && - BarrierArriveAndWait(build_barrier, WAIT_EVENT_HASH_BUILD_ELECTING)) + BarrierArriveAndWait(build_barrier, WAIT_EVENT_HASH_BUILD_ELECT)) { pstate->nbatch = nbatch; pstate->space_allowed = space_allowed; @@ -1076,7 +1076,7 @@ ExecParallelHashIncreaseNumBatches(HashJoinTable hashtable) * tuples. */ if (BarrierArriveAndWait(&pstate->grow_batches_barrier, - WAIT_EVENT_HASH_GROW_BATCHES_ELECTING)) + WAIT_EVENT_HASH_GROW_BATCHES_ELECT)) { dsa_pointer_atomic *buckets; ParallelHashJoinBatch *old_batch0; @@ -1186,7 +1186,7 @@ ExecParallelHashIncreaseNumBatches(HashJoinTable hashtable) case PHJ_GROW_BATCHES_ALLOCATING: /* Wait for the above to be finished. */ BarrierArriveAndWait(&pstate->grow_batches_barrier, - WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATING); + WAIT_EVENT_HASH_GROW_BATCHES_ALLOCATE); /* Fall through. */ case PHJ_GROW_BATCHES_REPARTITIONING: @@ -1199,7 +1199,7 @@ ExecParallelHashIncreaseNumBatches(HashJoinTable hashtable) ExecParallelHashMergeCounters(hashtable); /* Wait for the above to be finished. */ BarrierArriveAndWait(&pstate->grow_batches_barrier, - WAIT_EVENT_HASH_GROW_BATCHES_REPARTITIONING); + WAIT_EVENT_HASH_GROW_BATCHES_REPARTITION); /* Fall through. */ case PHJ_GROW_BATCHES_DECIDING: @@ -1210,7 +1210,7 @@ ExecParallelHashIncreaseNumBatches(HashJoinTable hashtable) * not helping. */ if (BarrierArriveAndWait(&pstate->grow_batches_barrier, - WAIT_EVENT_HASH_GROW_BATCHES_DECIDING)) + WAIT_EVENT_HASH_GROW_BATCHES_DECIDE)) { bool space_exhausted = false; bool extreme_skew_detected = false; @@ -1260,7 +1260,7 @@ ExecParallelHashIncreaseNumBatches(HashJoinTable hashtable) case PHJ_GROW_BATCHES_FINISHING: /* Wait for the above to complete. */ BarrierArriveAndWait(&pstate->grow_batches_barrier, - WAIT_EVENT_HASH_GROW_BATCHES_FINISHING); + WAIT_EVENT_HASH_GROW_BATCHES_FINISH); } } @@ -1509,7 +1509,7 @@ ExecParallelHashIncreaseNumBuckets(HashJoinTable hashtable) case PHJ_GROW_BUCKETS_ELECTING: /* Elect one participant to prepare to increase nbuckets. */ if (BarrierArriveAndWait(&pstate->grow_buckets_barrier, - WAIT_EVENT_HASH_GROW_BUCKETS_ELECTING)) + WAIT_EVENT_HASH_GROW_BUCKETS_ELECT)) { size_t size; dsa_pointer_atomic *buckets; @@ -1538,7 +1538,7 @@ ExecParallelHashIncreaseNumBuckets(HashJoinTable hashtable) case PHJ_GROW_BUCKETS_ALLOCATING: /* Wait for the above to complete. */ BarrierArriveAndWait(&pstate->grow_buckets_barrier, - WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATING); + WAIT_EVENT_HASH_GROW_BUCKETS_ALLOCATE); /* Fall through. */ case PHJ_GROW_BUCKETS_REINSERTING: @@ -1573,7 +1573,7 @@ ExecParallelHashIncreaseNumBuckets(HashJoinTable hashtable) CHECK_FOR_INTERRUPTS(); } BarrierArriveAndWait(&pstate->grow_buckets_barrier, - WAIT_EVENT_HASH_GROW_BUCKETS_REINSERTING); + WAIT_EVENT_HASH_GROW_BUCKETS_REINSERT); } } |