diff options
| author | Daniel Gustafsson <dgustafsson@postgresql.org> | 2025-03-11 12:02:38 +0100 |
|---|---|---|
| committer | Daniel Gustafsson <dgustafsson@postgresql.org> | 2025-03-11 12:02:38 +0100 |
| commit | 8dd7c7cd0a2605d5301266a6b67a569d6a305106 (patch) | |
| tree | 1da627dcaf9c5f7cc30de84292b2463858de8f58 /src/backend/executor/nodeAgg.c | |
| parent | dabccf45139a8c7c3c2e7683a943c31077e55a78 (diff) | |
| download | postgresql-8dd7c7cd0a2605d5301266a6b67a569d6a305106.tar.gz postgresql-8dd7c7cd0a2605d5301266a6b67a569d6a305106.zip | |
Replace EEOP_DONE with special steps for return/no return
Knowing when the side-effects of an expression is the intended result
of the execution, rather than the returnvalue, is important for being
able generate more efficient JITed code. This replaces EEOP_DONE with
two new steps: EEOP_DONE_RETURN and EEOP_DONE_NO_RETURN. Expressions
which return a value should use the former step; expressions used for
their side-effects which don't return value should use the latter.
Author: Andres Freund <andres@anarazel.de>
Co-authored-by: Daniel Gustafsson <daniel@yesql.se>
Reviewed-by: Andreas Karlsson <andreas@proxel.se>
Discussion: https://postgr.es/m/415721CE-7D2E-4B74-B5D9-1950083BA03E@yesql.se
Discussion: https://postgr.es/m/20191023163849.sosqbfs5yenocez3@alap3.anarazel.de
Diffstat (limited to 'src/backend/executor/nodeAgg.c')
| -rw-r--r-- | src/backend/executor/nodeAgg.c | 7 |
1 files changed, 2 insertions, 5 deletions
diff --git a/src/backend/executor/nodeAgg.c b/src/backend/executor/nodeAgg.c index ceb8c8a8039..b4a7698a0b3 100644 --- a/src/backend/executor/nodeAgg.c +++ b/src/backend/executor/nodeAgg.c @@ -816,11 +816,8 @@ advance_transition_function(AggState *aggstate, static void advance_aggregates(AggState *aggstate) { - bool dummynull; - - ExecEvalExprSwitchContext(aggstate->phase->evaltrans, - aggstate->tmpcontext, - &dummynull); + ExecEvalExprNoReturnSwitchContext(aggstate->phase->evaltrans, + aggstate->tmpcontext); } /* |