aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor/functions.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2014-02-03 14:46:51 -0500
committerTom Lane <tgl@sss.pgh.pa.us>2014-02-03 14:47:17 -0500
commit0def2573c5f0ff127d0c7dc12ec7da56ae6fb7fe (patch)
tree0102e0e32b5b86dce351d9e77200dc019a25df2f /src/backend/executor/functions.c
parent80353f35285f89382cea7fc543580827f0465e69 (diff)
downloadpostgresql-0def2573c5f0ff127d0c7dc12ec7da56ae6fb7fe.tar.gz
postgresql-0def2573c5f0ff127d0c7dc12ec7da56ae6fb7fe.zip
Fix *-qualification of named parameters in SQL-language functions.
Given a composite-type parameter named x, "$1.*" worked fine, but "x.*" not so much. This has been broken since named parameter references were added in commit 9bff0780cf5be2193a5bad0d3df2dbe143085264, so patch back to 9.2. Per bug #9085 from Hardy Falk.
Diffstat (limited to 'src/backend/executor/functions.c')
-rw-r--r--src/backend/executor/functions.c8
1 files changed, 8 insertions, 0 deletions
diff --git a/src/backend/executor/functions.c b/src/backend/executor/functions.c
index 9c179707f40..b5af19acf1a 100644
--- a/src/backend/executor/functions.c
+++ b/src/backend/executor/functions.c
@@ -310,6 +310,11 @@ sql_fn_post_column_ref(ParseState *pstate, ColumnRef *cref, Node *var)
* (the first possibility takes precedence)
* A.B.C A = function name, B = record-typed parameter name,
* C = field name
+ * A.* Whole-row reference to composite parameter A.
+ * A.B.* Same, with A = function name, B = parameter name
+ *
+ * Here, it's sufficient to ignore the "*" in the last two cases --- the
+ * main parser will take care of expanding the whole-row reference.
*----------
*/
nnames = list_length(cref->fields);
@@ -317,6 +322,9 @@ sql_fn_post_column_ref(ParseState *pstate, ColumnRef *cref, Node *var)
if (nnames > 3)
return NULL;
+ if (IsA(llast(cref->fields), A_Star))
+ nnames--;
+
field1 = (Node *) linitial(cref->fields);
Assert(IsA(field1, String));
name1 = strVal(field1);