diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2017-07-02 14:03:41 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2017-07-02 14:03:41 -0400 |
commit | de3de0afd7da7b432e219aa38bde248fc5c5206a (patch) | |
tree | 3cb8ff55a05b17aa588cf6efd6558b12e44e16ff /src/backend/executor/execUtils.c | |
parent | 2dca03439f1f88e9102aa6bf613b434be0697dae (diff) | |
download | postgresql-de3de0afd7da7b432e219aa38bde248fc5c5206a.tar.gz postgresql-de3de0afd7da7b432e219aa38bde248fc5c5206a.zip |
Improve TAP test function PostgresNode::poll_query_until().
Add an optional "expected" argument to override the default assumption
that we're waiting for the query to return "t". This allows replacing
a handwritten polling loop in recovery/t/007_sync_rep.pl with use of
poll_query_until(); AFAICS that's the only remaining ad-hoc polling
loop in our TAP tests.
Change poll_query_until() to probe ten times per second not once per
second. Like some similar changes I've been making recently, the
one-second interval seems to be rooted in ancient traditions rather
than the actual likely wait duration on modern machines. I'd consider
reducing it further if there were a convenient way to spawn just one
psql for the whole loop rather than one per probe attempt.
Discussion: https://postgr.es/m/12486.1498938782@sss.pgh.pa.us
Diffstat (limited to 'src/backend/executor/execUtils.c')
0 files changed, 0 insertions, 0 deletions