diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2010-02-08 04:33:55 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2010-02-08 04:33:55 +0000 |
| commit | 0a469c87692d15a22eaa69d4b3a43dd8e278dd64 (patch) | |
| tree | 34353dece3a2a8da2c599562685831bdcb14080e /src/backend/executor/execUtils.c | |
| parent | 1ddc2703a936d03953657f43345460b9242bbed1 (diff) | |
| download | postgresql-0a469c87692d15a22eaa69d4b3a43dd8e278dd64.tar.gz postgresql-0a469c87692d15a22eaa69d4b3a43dd8e278dd64.zip | |
Remove old-style VACUUM FULL (which was known for a little while as
VACUUM FULL INPLACE), along with a boatload of subsidiary code and complexity.
Per discussion, the use case for this method of vacuuming is no longer large
enough to justify maintaining it; not to mention that we don't wish to invest
the work that would be needed to make it play nicely with Hot Standby.
Aside from the code directly related to old-style VACUUM FULL, this commit
removes support for certain WAL record types that could only be generated
within VACUUM FULL, redirect-pointer removal in heap_page_prune, and
nontransactional generation of cache invalidation sinval messages (the last
being the sticking point for Hot Standby).
We still have to retain all code that copes with finding HEAP_MOVED_OFF and
HEAP_MOVED_IN flag bits on existing tuples. This can't be removed as long
as we want to support in-place update from pre-9.0 databases.
Diffstat (limited to 'src/backend/executor/execUtils.c')
| -rw-r--r-- | src/backend/executor/execUtils.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/backend/executor/execUtils.c b/src/backend/executor/execUtils.c index 5d6473dfc69..151e50b63f9 100644 --- a/src/backend/executor/execUtils.c +++ b/src/backend/executor/execUtils.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.169 2010/01/02 17:53:56 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execUtils.c,v 1.170 2010/02/08 04:33:54 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -977,8 +977,7 @@ ExecCloseIndices(ResultRelInfo *resultRelInfo) List * ExecInsertIndexTuples(TupleTableSlot *slot, ItemPointer tupleid, - EState *estate, - bool is_vacuum_full) + EState *estate) { List *result = NIL; ResultRelInfo *resultRelInfo; @@ -1070,12 +1069,8 @@ ExecInsertIndexTuples(TupleTableSlot *slot, * For a deferrable unique index, we tell the index AM to just detect * possible non-uniqueness, and we add the index OID to the result * list if further checking is needed. - * - * Special hack: we suppress unique-index checks if we are being - * called from VACUUM FULL, since VACUUM FULL may need to move dead - * tuples that have the same keys as live ones. */ - if (is_vacuum_full || !indexRelation->rd_index->indisunique) + if (!indexRelation->rd_index->indisunique) checkUnique = UNIQUE_CHECK_NO; else if (indexRelation->rd_index->indimmediate) checkUnique = UNIQUE_CHECK_YES; |