aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor/execProcnode.c
diff options
context:
space:
mode:
authorTom Lane <tgl@sss.pgh.pa.us>2020-07-24 15:43:56 -0400
committerTom Lane <tgl@sss.pgh.pa.us>2020-07-24 15:43:56 -0400
commit79d6d1a277ee1cdda90f9a66d7970ac3885822de (patch)
tree862676fbedfc5bed551ffda81253cd662cbefe9d /src/backend/executor/execProcnode.c
parent2f2007fbb255be178aca586780967f43885203a7 (diff)
downloadpostgresql-79d6d1a277ee1cdda90f9a66d7970ac3885822de.tar.gz
postgresql-79d6d1a277ee1cdda90f9a66d7970ac3885822de.zip
Replace TS_execute's TS_EXEC_CALC_NOT flag with TS_EXEC_SKIP_NOT.
It's fairly silly that ignoring NOT subexpressions is TS_execute's default behavior. It's wrong on its face and it encourages errors of omission. Moreover, the only two remaining callers that aren't specifying CALC_NOT are in ts_headline calculations, and it's very arguable that those are bugs: if you've specified "!foo" in your query, why would you want to get a headline that includes "foo"? Hence, rip that out and change the default behavior to be to calculate NOT accurately. As a concession to the slim chance that there is still somebody somewhere who needs the incorrect behavior, provide a new SKIP_NOT flag to explicitly request that. Back-patch into v13, mainly because it seems better to change this at the same time as the previous commit's rejiggering of TS_execute related APIs. Any outside callers affected by this change are probably also affected by that one. Discussion: https://postgr.es/m/CALT9ZEE-aLotzBg-pOp2GFTesGWVYzXA3=mZKzRDa_OKnLF7Mg@mail.gmail.com
Diffstat (limited to 'src/backend/executor/execProcnode.c')
0 files changed, 0 insertions, 0 deletions