diff options
| author | Bruce Momjian <bruce@momjian.us> | 2021-04-08 11:16:01 -0400 |
|---|---|---|
| committer | Bruce Momjian <bruce@momjian.us> | 2021-04-08 11:16:01 -0400 |
| commit | 0f61727b75b93915ca9a9f20c996ed7020996a38 (patch) | |
| tree | edde84ea5ff138952c506bbffe93baa848c79fb8 /src/backend/executor/execParallel.c | |
| parent | 5844c23dc50508aefeb8183be45f4ee99e9dec17 (diff) | |
| download | postgresql-0f61727b75b93915ca9a9f20c996ed7020996a38.tar.gz postgresql-0f61727b75b93915ca9a9f20c996ed7020996a38.zip | |
Fixes for query_id feature
Ignore parallel workers in pg_stat_statements
Oversight in 4f0b0966c8 which exposed queryid in parallel workers.
Counters are aggregated by the main backend process so parallel workers
would report duplicated activity, and could also report activity for the
wrong entry as they are only aware of the top level queryid.
Fix thinko in pg_stat_get_activity when retrieving the queryid.
Remove unnecessary call to pgstat_report_queryid().
Reported-by: Amit Kapila, Andres Freund, Thomas Munro
Discussion: https://postgr.es/m/20210408051735.lfbdzun5zdlax5gd@alap3.anarazel.de p634GTSOqnDW86Owrn6qDAVosC5dJjXjp7BMfc5Gz1Q@mail.gmail.com
Author: Julien Rouhaud
Diffstat (limited to 'src/backend/executor/execParallel.c')
| -rw-r--r-- | src/backend/executor/execParallel.c | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/src/backend/executor/execParallel.c b/src/backend/executor/execParallel.c index d104a19767c..4fca8782b2f 100644 --- a/src/backend/executor/execParallel.c +++ b/src/backend/executor/execParallel.c @@ -1426,7 +1426,6 @@ ParallelQueryMain(dsm_segment *seg, shm_toc *toc) /* Report workers' query and queryId for monitoring purposes */ pgstat_report_activity(STATE_RUNNING, debug_query_string); - pgstat_report_queryid(queryDesc->plannedstmt->queryId, false); /* Attach to the dynamic shared memory area. */ area_space = shm_toc_lookup(toc, PARALLEL_KEY_DSA, false); |