aboutsummaryrefslogtreecommitdiff
path: root/src/backend/executor/execMain.c
diff options
context:
space:
mode:
authorAlvaro Herrera <alvherre@alvh.no-ip.org>2022-11-30 12:07:03 +0100
committerAlvaro Herrera <alvherre@alvh.no-ip.org>2022-11-30 12:07:03 +0100
commit599b33b9492dfefd1219c1d31801f40b3ba90b0d (patch)
tree37e6681f524f31d78072cdf7498d869993b94030 /src/backend/executor/execMain.c
parentd2a4490401f2ddc878134a1fd75ef4482e403e47 (diff)
downloadpostgresql-599b33b9492dfefd1219c1d31801f40b3ba90b0d.tar.gz
postgresql-599b33b9492dfefd1219c1d31801f40b3ba90b0d.zip
Stop accessing checkAsUser via RTE in some cases
A future commit will move the checkAsUser field from RangeTblEntry to a new node that, unlike RTEs, will only be created for tables mentioned in the query but not for the inheritance child relations added to the query by the planner. So, checkAsUser value for a given child relation will have to be obtained by referring to that for its ancestor mentioned in the query. In preparation, it seems better to expand the use of RelOptInfo.userid during planning in place of rte->checkAsUser so that there will be fewer places to adjust for the above change. Given that the child-to-ancestor mapping is not available during the execution of a given "child" ForeignScan node, add a checkAsUser field to ForeignScan to carry the child relation's RelOptInfo.userid. Author: Amit Langote <amitlangote09@gmail.com> Discussion: https://postgr.es/m/CA+HiwqGFCs2uq7VRKi7g+FFKbP6Ea_2_HkgZb2HPhUfaAKT3ng@mail.gmail.com
Diffstat (limited to 'src/backend/executor/execMain.c')
-rw-r--r--src/backend/executor/execMain.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c
index e301c687e37..8bf2ba1c04a 100644
--- a/src/backend/executor/execMain.c
+++ b/src/backend/executor/execMain.c
@@ -631,7 +631,7 @@ ExecCheckRTEPerms(RangeTblEntry *rte)
* call it once in ExecCheckRTPerms and pass the userid down from there.
* But for now, no need for the extra clutter.
*/
- userid = rte->checkAsUser ? rte->checkAsUser : GetUserId();
+ userid = OidIsValid(rte->checkAsUser) ? rte->checkAsUser : GetUserId();
/*
* We must have *all* the requiredPerms bits, but some of the bits can be