diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2007-09-07 20:59:26 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2007-09-07 20:59:26 +0000 |
| commit | 0a51e7073c045b5fce50092dae19f398f7b38e16 (patch) | |
| tree | 8f33ac25cc0653195f86b76f724b52360f3fbc80 /src/backend/executor/execMain.c | |
| parent | 85e79a4a83d6f6fb505474a720eb32fd88067c16 (diff) | |
| download | postgresql-0a51e7073c045b5fce50092dae19f398f7b38e16.tar.gz postgresql-0a51e7073c045b5fce50092dae19f398f7b38e16.zip | |
Don't take ProcArrayLock while exiting a transaction that has no XID; there is
no need for serialization against snapshot-taking because the xact doesn't
affect anyone else's snapshot anyway. Per discussion. Also, move various
info about the interlocking of transactions and snapshots out of code comments
and into a hopefully-more-cohesive discussion in access/transam/README.
Also, remove a couple of now-obsolete comments about having to force some WAL
to be written to persuade RecordTransactionCommit to do its thing.
Diffstat (limited to 'src/backend/executor/execMain.c')
| -rw-r--r-- | src/backend/executor/execMain.c | 8 |
1 files changed, 1 insertions, 7 deletions
diff --git a/src/backend/executor/execMain.c b/src/backend/executor/execMain.c index 322c1d1a27d..7e5873b89df 100644 --- a/src/backend/executor/execMain.c +++ b/src/backend/executor/execMain.c @@ -26,7 +26,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.296 2007/08/15 21:39:50 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/executor/execMain.c,v 1.297 2007/09/07 20:59:26 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -2635,12 +2635,6 @@ OpenIntoRel(QueryDesc *queryDesc) /* * We can skip WAL-logging the insertions, unless PITR is in use. - * - * Note that for a non-temp INTO table, this is safe only because we know - * that the catalog changes above will have been WAL-logged, and so - * RecordTransactionCommit will think it needs to WAL-log the eventual - * transaction commit. Else the commit might be lost, even though all the - * data is safely fsync'd ... */ estate->es_into_relation_use_wal = XLogArchivingActive(); estate->es_into_relation_descriptor = intoRelationDesc; |