diff options
| author | Jeff Davis <jdavis@postgresql.org> | 2019-12-06 11:47:59 -0800 |
|---|---|---|
| committer | Jeff Davis <jdavis@postgresql.org> | 2019-12-06 11:49:59 -0800 |
| commit | 30d47723fd151641e89d18ce775f1a102ff07ae2 (patch) | |
| tree | 87efee485dfc64b3ac7b5581afbb0f6295c87870 /src/backend/executor/execGrouping.c | |
| parent | fbbf68094c5ff3d513969d072126c92932e484da (diff) | |
| download | postgresql-30d47723fd151641e89d18ce775f1a102ff07ae2.tar.gz postgresql-30d47723fd151641e89d18ce775f1a102ff07ae2.zip | |
Fix comments in execGrouping.c
Commit 5dfc1981 missed updating some comments.
Also, fix a comment typo found in passing.
Author: Jeff Davis
Discussion: https://postgr.es/m/9723131d247b919f94699152647fa87ee0bc02c2.camel%40j-davis.com
Diffstat (limited to 'src/backend/executor/execGrouping.c')
| -rw-r--r-- | src/backend/executor/execGrouping.c | 11 |
1 files changed, 3 insertions, 8 deletions
diff --git a/src/backend/executor/execGrouping.c b/src/backend/executor/execGrouping.c index 7bc5e405bcc..e361143094c 100644 --- a/src/backend/executor/execGrouping.c +++ b/src/backend/executor/execGrouping.c @@ -382,12 +382,9 @@ FindTupleHashEntry(TupleHashTable hashtable, TupleTableSlot *slot, /* * Compute the hash value for a tuple * - * The passed-in key is a pointer to TupleHashEntryData. In an actual hash - * table entry, the firstTuple field points to a tuple (in MinimalTuple - * format). LookupTupleHashEntry sets up a dummy TupleHashEntryData with a - * NULL firstTuple field --- that cues us to look at the inputslot instead. - * This convention avoids the need to materialize virtual input tuples unless - * they actually need to get copied into the table. + * If tuple is NULL, use the input slot instead. This convention avoids the + * need to materialize virtual input tuples unless they actually need to get + * copied into the table. * * Also, the caller must select an appropriate memory context for running * the hash functions. (dynahash.c doesn't change CurrentMemoryContext.) @@ -455,8 +452,6 @@ TupleHashTableHash(struct tuplehash_hash *tb, const MinimalTuple tuple) /* * See whether two tuples (presumably of the same hash value) match - * - * As above, the passed pointers are pointers to TupleHashEntryData. */ static int TupleHashTableMatch(struct tuplehash_hash *tb, const MinimalTuple tuple1, const MinimalTuple tuple2) |