diff options
| author | Michael Paquier <michael@paquier.xyz> | 2022-07-27 19:50:06 +0900 |
|---|---|---|
| committer | Michael Paquier <michael@paquier.xyz> | 2022-07-27 19:50:06 +0900 |
| commit | ce3049b0215b63744d11c0ce3ac6afdb67fc2ff0 (patch) | |
| tree | 0db87fb5a51a1fc4905cd0685336632d85bc10fa /src/backend/commands | |
| parent | d0b193c0fad13cf35122b0d3dc805c76e323e8bf (diff) | |
| download | postgresql-ce3049b0215b63744d11c0ce3ac6afdb67fc2ff0.tar.gz postgresql-ce3049b0215b63744d11c0ce3ac6afdb67fc2ff0.zip | |
Refactor code in charge of grabbing the relations of a subscription
GetSubscriptionRelations() and GetSubscriptionNotReadyRelations() share
mostly the same code, which scans pg_subscription_rel and fetches all
the relations of a given subscription. The only difference is that the
second routine looks for all the relations not in a ready state. This
commit refactors the code to use a single routine, shaving a bit of
code.
Author: Vignesh C
Reviewed-By: Kyotaro Horiguchi, Amit Kapila, Michael Paquier, Peter
Smith
Discussion: https://postgr.es/m/CALDaNm0eW-9g4G_EzHebnFT5zZoasWCS_EzZQ5BgnLZny9S=pg@mail.gmail.com
Diffstat (limited to 'src/backend/commands')
| -rw-r--r-- | src/backend/commands/subscriptioncmds.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/commands/subscriptioncmds.c b/src/backend/commands/subscriptioncmds.c index bd0cc0848d7..f73dfb6067f 100644 --- a/src/backend/commands/subscriptioncmds.c +++ b/src/backend/commands/subscriptioncmds.c @@ -814,7 +814,7 @@ AlterSubscription_refresh(Subscription *sub, bool copy_data, pubrel_names = fetch_table_list(wrconn, sub->publications); /* Get local table list. */ - subrel_states = GetSubscriptionRelations(sub->oid); + subrel_states = GetSubscriptionRelations(sub->oid, false); /* * Build qsorted array of local table oids for faster lookup. This can @@ -1494,7 +1494,7 @@ DropSubscription(DropSubscriptionStmt *stmt, bool isTopLevel) * the apply and tablesync workers and they can't restart because of * exclusive lock on the subscription. */ - rstates = GetSubscriptionNotReadyRelations(subid); + rstates = GetSubscriptionRelations(subid, true); foreach(lc, rstates) { SubscriptionRelState *rstate = (SubscriptionRelState *) lfirst(lc); |