diff options
author | Bruce Momjian <bruce@momjian.us> | 2006-02-12 20:08:29 +0000 |
---|---|---|
committer | Bruce Momjian <bruce@momjian.us> | 2006-02-12 20:08:29 +0000 |
commit | 6e51bcef8e9f7d5f9f48fd30312a364bf5c58564 (patch) | |
tree | 60c733d402406e776a5bc97c39348f7f15b07d7b /src/backend/commands/variable.c | |
parent | 3e682635e3dae393082a853c3454e79e8c639e5d (diff) | |
download | postgresql-6e51bcef8e9f7d5f9f48fd30312a364bf5c58564.tar.gz postgresql-6e51bcef8e9f7d5f9f48fd30312a364bf5c58564.zip |
Back out patch pending review.
---------------------------------------------------------------------------
> I've now tested this patch at home w/ 8.2HEAD and it seems to fix the
> bug. I plan on testing it under 8.1.2 at work tommorow with
> mod_auth_krb5, etc, and expect it'll work there. Assuming all goes
> well and unless someone objects I'll forward the patch to -patches.
> It'd be great to have this fixed as it'll allow us to use Kerberos to
> authenticate to phppgadmin and other web-based tools which use
> Postgres.
While playing with this patch under 8.1.2 at home I discovered a
mistake in how I manually applied one of the hunks to fe-auth.c.
Basically, the base code had changed and so the patch needed to be
modified slightly. This is because the code no longer either has a
freeable pointer under 'name' or has 'name' as NULL.
The attached patch correctly frees the string from pg_krb5_authname
(where it had been strdup'd) if and only if pg_krb5_authname returned
a string (as opposed to falling through and having name be set using
name = pw->name;). Also added a comment to this effect.
Please review.
Stephen Frost (sfrost@snowman.net) wrote:
Diffstat (limited to 'src/backend/commands/variable.c')
0 files changed, 0 insertions, 0 deletions