diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2022-10-17 14:02:05 -0400 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2022-10-17 14:02:05 -0400 |
| commit | 8272749e8ca1dbbcb5f8cf5632ec26a573ac3111 (patch) | |
| tree | aeee7a1615af0d87b69db96f38d734e8d4782f70 /src/backend/commands/typecmds.c | |
| parent | 797e313dc9aed83e28e9f1d08a281ea48c560cd2 (diff) | |
| download | postgresql-8272749e8ca1dbbcb5f8cf5632ec26a573ac3111.tar.gz postgresql-8272749e8ca1dbbcb5f8cf5632ec26a573ac3111.zip | |
Record dependencies of a cast on other casts that it requires.
When creating a cast that uses a conversion function, we've
historically allowed the input and result types to be
binary-compatible with the function's input and result types,
rather than necessarily being identical. This means that the new
cast is logically dependent on the binary-compatible cast or casts
that it references: if those are defined by pg_cast entries, and you
try to restore the new cast without having defined them, it'll fail.
Hence, we should make pg_depend entries to record these dependencies
so that pg_dump knows that there is an ordering requirement.
This is not the only place where we allow such shortcuts; aggregate
functions for example are similarly lax, and in principle should gain
similar dependencies. However, for now it seems sufficient to fix
the cast-versus-cast case, as pg_dump's other ordering heuristics
should keep it out of trouble for other object types.
Per report from David TuroĊ; thanks also to Robert Haas for
preliminary investigation. I considered back-patching, but
seeing that this issue has existed for many years without
previous reports, it's not clear it's worth the trouble.
Moreover, back-patching wouldn't be enough to ensure that the
new pg_depend entries exist in existing databases anyway.
Discussion: https://postgr.es/m/OF0A160F3E.578B15D1-ONC12588DA.003E4857-C12588DA.0045A428@notes.linuxbox.cz
Diffstat (limited to 'src/backend/commands/typecmds.c')
| -rw-r--r-- | src/backend/commands/typecmds.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/commands/typecmds.c b/src/backend/commands/typecmds.c index 33b64fd2793..b7c3dded170 100644 --- a/src/backend/commands/typecmds.c +++ b/src/backend/commands/typecmds.c @@ -1705,7 +1705,9 @@ DefineRange(ParseState *pstate, CreateRangeStmt *stmt) &castFuncOid); /* Create cast from the range type to its multirange type */ - CastCreate(typoid, multirangeOid, castFuncOid, 'e', 'f', DEPENDENCY_INTERNAL); + CastCreate(typoid, multirangeOid, castFuncOid, InvalidOid, InvalidOid, + COERCION_CODE_EXPLICIT, COERCION_METHOD_FUNCTION, + DEPENDENCY_INTERNAL); pfree(multirangeArrayName); |