diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2002-01-03 23:21:32 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2002-01-03 23:21:32 +0000 |
| commit | dc6b4deb9717a9f03b2f93baca9f93f13786e26b (patch) | |
| tree | 586c04579f3337cc8fdbbc342eefbb0bdf21e607 /src/backend/commands/trigger.c | |
| parent | d02f0aaa3b7313cabd9e64deb34ab630832730ce (diff) | |
| download | postgresql-dc6b4deb9717a9f03b2f93baca9f93f13786e26b.tar.gz postgresql-dc6b4deb9717a9f03b2f93baca9f93f13786e26b.zip | |
Require ownership permission for CREATE INDEX, per bug report.
Disallow CREATE INDEX on system catalogs, non-tables (views, sequences, etc).
Disallow CREATE/DROP TRIGGER on system catalogs, non-tables.
Disallow ALTER TABLE ADD/DROP CONSTRAINT on system catalogs.
Disallow FOREIGN KEY reference to non-table.
None of these things can actually work in the present system structure,
but the code was letting them pass without complaint.
Diffstat (limited to 'src/backend/commands/trigger.c')
| -rw-r--r-- | src/backend/commands/trigger.c | 17 |
1 files changed, 15 insertions, 2 deletions
diff --git a/src/backend/commands/trigger.c b/src/backend/commands/trigger.c index 008774e5a8e..8eedda03aaf 100644 --- a/src/backend/commands/trigger.c +++ b/src/backend/commands/trigger.c @@ -7,7 +7,7 @@ * Portions Copyright (c) 1994, Regents of the University of California * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.99 2001/11/16 16:31:16 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/commands/trigger.c,v 1.100 2002/01/03 23:21:23 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -105,6 +105,10 @@ CreateTrigger(CreateTrigStmt *stmt) rel = heap_openr(stmt->relname, AccessExclusiveLock); + if (rel->rd_rel->relkind != RELKIND_RELATION) + elog(ERROR, "CreateTrigger: relation \"%s\" is not a table", + stmt->relname); + TRIGGER_CLEAR_TYPE(tgtype); if (stmt->before) TRIGGER_SETT_BEFORE(tgtype); @@ -315,11 +319,20 @@ DropTrigger(DropTrigStmt *stmt) int found = 0; int tgfound = 0; + if (!allowSystemTableMods && IsSystemRelationName(stmt->relname)) + elog(ERROR, "DropTrigger: can't drop trigger for system relation %s", + stmt->relname); + if (!pg_ownercheck(GetUserId(), stmt->relname, RELNAME)) - elog(ERROR, "%s: %s", stmt->relname, aclcheck_error_strings[ACLCHECK_NOT_OWNER]); + elog(ERROR, "%s: %s", stmt->relname, + aclcheck_error_strings[ACLCHECK_NOT_OWNER]); rel = heap_openr(stmt->relname, AccessExclusiveLock); + if (rel->rd_rel->relkind != RELKIND_RELATION) + elog(ERROR, "DropTrigger: relation \"%s\" is not a table", + stmt->relname); + /* * Search pg_trigger, delete target trigger, count remaining triggers * for relation. Note this is OK only because we have |