diff options
| author | Richard Guo <rguo@postgresql.org> | 2025-06-26 12:17:12 +0900 |
|---|---|---|
| committer | Richard Guo <rguo@postgresql.org> | 2025-06-26 12:17:12 +0900 |
| commit | 5069fef1cfae271ca62e254b16dc831145bc5a4f (patch) | |
| tree | f1cbf6372ba720a875a7143004612505311e1657 /src/backend/commands/tablecmds.c | |
| parent | 62a47aea1d8d8ea36e63fe6dd3d9891452a3f968 (diff) | |
| download | postgresql-5069fef1cfae271ca62e254b16dc831145bc5a4f.tar.gz postgresql-5069fef1cfae271ca62e254b16dc831145bc5a4f.zip | |
Expand virtual generated columns for ALTER COLUMN TYPE
For the subcommand ALTER COLUMN TYPE of the ALTER TABLE command, the
USING expression may reference virtual generated columns. These
columns must be expanded before the expression is fed through
expression_planner and the expression-execution machinery. Failing to
do so can result in incorrect rewrite decisions, and can also lead to
"ERROR: unexpected virtual generated column reference".
Reported-by: Alexander Lakhin <exclusion@gmail.com>
Reviewed-by: jian he <jian.universality@gmail.com>
Discussion: https://postgr.es/m/b5f96b24-ccac-47fd-9e20-14681b894f36@gmail.com
Diffstat (limited to 'src/backend/commands/tablecmds.c')
| -rw-r--r-- | src/backend/commands/tablecmds.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/src/backend/commands/tablecmds.c b/src/backend/commands/tablecmds.c index 074ddb6b9cd..1c3ad74e7b9 100644 --- a/src/backend/commands/tablecmds.c +++ b/src/backend/commands/tablecmds.c @@ -14484,6 +14484,9 @@ ATPrepAlterColumnType(List **wqueue, /* Fix collations after all else */ assign_expr_collations(pstate, transform); + /* Expand virtual generated columns in the expr. */ + transform = expand_generated_columns_in_expr(transform, rel, 1); + /* Plan the expr now so we can accurately assess the need to rewrite. */ transform = (Node *) expression_planner((Expr *) transform); |