diff options
| author | Neil Conway <neilc@samurai.com> | 2003-12-14 00:34:47 +0000 |
|---|---|---|
| committer | Neil Conway <neilc@samurai.com> | 2003-12-14 00:34:47 +0000 |
| commit | fef0c8345a96f953ebfe59fcc22a9eeb980b25c5 (patch) | |
| tree | 853c777b605251bd9143a855d21cd12e62c9be06 /src/backend/commands/sequence.c | |
| parent | 81e9455150bcb1ebc5774c7c4fd4d5ed6ba8ac1b (diff) | |
| download | postgresql-fef0c8345a96f953ebfe59fcc22a9eeb980b25c5.tar.gz postgresql-fef0c8345a96f953ebfe59fcc22a9eeb980b25c5.zip | |
I posted some bufmgr cleanup a few weeks ago, but it conflicted with
some concurrent changes Jan was making to the bufmgr. Here's an
updated version of the patch -- it should apply cleanly to CVS
HEAD and passes the regression tests.
This patch makes the following changes:
- remove the UnlockAndReleaseBuffer() and UnlockAndWriteBuffer()
macros, and replace uses of them with calls to the appropriate
functions.
- remove a bunch of #ifdef BMTRACE code: it is ugly & broken
(i.e. it doesn't compile)
- make BufferReplace() return a bool, not an int
- cleanup some logic in bufmgr.c; should be functionality
equivalent to the previous code, just cleaner now
- remove the BM_PRIVATE flag as it is unused
- improve a few comments, etc.
Diffstat (limited to 'src/backend/commands/sequence.c')
| -rw-r--r-- | src/backend/commands/sequence.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/src/backend/commands/sequence.c b/src/backend/commands/sequence.c index 39a62448cff..54acb5b89cd 100644 --- a/src/backend/commands/sequence.c +++ b/src/backend/commands/sequence.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/sequence.c,v 1.105 2003/11/29 19:51:47 pgsql Exp $ + * $PostgreSQL: pgsql/src/backend/commands/sequence.c,v 1.106 2003/12/14 00:34:47 neilc Exp $ * *------------------------------------------------------------------------- */ @@ -1104,7 +1104,8 @@ seq_redo(XLogRecPtr lsn, XLogRecord *record) PageSetLSN(page, lsn); PageSetSUI(page, ThisStartUpID); - UnlockAndWriteBuffer(buffer); + LockBuffer(buffer, BUFFER_LOCK_UNLOCK); + WriteBuffer(buffer); } void |