diff options
| author | Peter Eisentraut <peter@eisentraut.org> | 2022-07-01 10:51:45 +0200 |
|---|---|---|
| committer | Peter Eisentraut <peter@eisentraut.org> | 2022-07-01 11:23:15 +0200 |
| commit | d746021de18baf0f29eff0388204a0664f41eb8b (patch) | |
| tree | 21074e7935e62cd054e702d79e5c1fe7c8544733 /src/backend/commands/policy.c | |
| parent | 7c2d6f8d3400edab2b91de7765db9ec71235fac9 (diff) | |
| download | postgresql-d746021de18baf0f29eff0388204a0664f41eb8b.tar.gz postgresql-d746021de18baf0f29eff0388204a0664f41eb8b.zip | |
Add construct_array_builtin, deconstruct_array_builtin
There were many calls to construct_array() and deconstruct_array() for
built-in types, for example, when dealing with system catalog columns.
These all hardcoded the type attributes necessary to pass to these
functions.
To simplify this a bit, add construct_array_builtin(),
deconstruct_array_builtin() as wrappers that centralize this hardcoded
knowledge. This simplifies many call sites and reduces the amount of
hardcoded stuff that is spread around.
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
Discussion: https://www.postgresql.org/message-id/flat/2914356f-9e5f-8c59-2995-5997fc48bcba%40enterprisedb.com
Diffstat (limited to 'src/backend/commands/policy.c')
| -rw-r--r-- | src/backend/commands/policy.c | 9 |
1 files changed, 3 insertions, 6 deletions
diff --git a/src/backend/commands/policy.c b/src/backend/commands/policy.c index a59ee3b9477..d9dff9ecaab 100644 --- a/src/backend/commands/policy.c +++ b/src/backend/commands/policy.c @@ -500,8 +500,7 @@ RemoveRoleFromObjectPolicy(Oid roleid, Oid classid, Oid policy_id) memset(isnull, 0, sizeof(isnull)); /* This is the array for the new tuple */ - role_ids = construct_array(role_oids, num_roles, OIDOID, - sizeof(Oid), true, TYPALIGN_INT); + role_ids = construct_array_builtin(role_oids, num_roles, OIDOID); replaces[Anum_pg_policy_polroles - 1] = true; values[Anum_pg_policy_polroles - 1] = PointerGetDatum(role_ids); @@ -617,8 +616,7 @@ CreatePolicy(CreatePolicyStmt *stmt) /* Collect role ids */ role_oids = policy_role_list_to_array(stmt->roles, &nitems); - role_ids = construct_array(role_oids, nitems, OIDOID, - sizeof(Oid), true, TYPALIGN_INT); + role_ids = construct_array_builtin(role_oids, nitems, OIDOID); /* Parse the supplied clause */ qual_pstate = make_parsestate(NULL); @@ -801,8 +799,7 @@ AlterPolicy(AlterPolicyStmt *stmt) if (stmt->roles != NULL) { role_oids = policy_role_list_to_array(stmt->roles, &nitems); - role_ids = construct_array(role_oids, nitems, OIDOID, - sizeof(Oid), true, TYPALIGN_INT); + role_ids = construct_array_builtin(role_oids, nitems, OIDOID); } /* Get id of table. Also handles permissions checks. */ |