Restructure system-catalog index updating logic. Instead of having

hardwired lists of index names for each catalog, use the relcache's
mechanism for caching lists of OIDs of indexes of any table.  This
reduces the common case of updating system catalog indexes to a single
line, makes it much easier to add a new system index (in fact, you
can now do so on-the-fly if you want to), and as a nice side benefit
improves performance a little.  Per recent pghackers discussion.

1 files changed, 3 insertions, 9 deletions

diff --git a/src/backend/commands/functioncmds.c b/src/backend/commands/functioncmds.c
index ea858d55716..944ae192a0d 100644
--- a/src/backend/commands/functioncmds.c
+++ b/src/backend/commands/functioncmds.c
@@ -9,7 +9,7 @@
  *
  *
  * IDENTIFICATION
- *	  $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.15 2002/07/29 23:44:44 tgl Exp $
+ *	  $Header: /cvsroot/pgsql/src/backend/commands/functioncmds.c,v 1.16 2002/08/05 03:29:16 tgl Exp $
  *
  * DESCRIPTION
  *	  These routines take the parse tree and pick out the
@@ -685,16 +685,10 @@ CreateCast(CreateCastStmt *stmt)
 		nulls[i] = ' ';
 
 	tuple = heap_formtuple(RelationGetDescr(relation), values, nulls);
-	simple_heap_insert(relation, tuple);
 
-	if (RelationGetForm(relation)->relhasindex)
-	{
-		Relation	idescs[Num_pg_cast_indices];
+	simple_heap_insert(relation, tuple);
 
-		CatalogOpenIndices(Num_pg_cast_indices, Name_pg_cast_indices, idescs);
-		CatalogIndexInsert(idescs, Num_pg_cast_indices, relation, tuple);
-		CatalogCloseIndices(Num_pg_cast_indices, idescs);
-	}
+	CatalogUpdateIndexes(relation, tuple);
 
 	myself.classId = RelationGetRelid(relation);
 	myself.objectId = HeapTupleGetOid(tuple);