diff options
| author | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2022-11-03 20:40:21 +0100 |
|---|---|---|
| committer | Alvaro Herrera <alvherre@alvh.no-ip.org> | 2022-11-03 20:40:21 +0100 |
| commit | b0284bfb1db5f71778f123754f2eab362b198993 (patch) | |
| tree | de8ac91a21fe1c1a970ae593166ec97bca74bf3b /src/backend/commands/dbcommands.c | |
| parent | 2fe4c7384f469e077928cd40fa1da4bd05598f1f (diff) | |
| download | postgresql-b0284bfb1db5f71778f123754f2eab362b198993.tar.gz postgresql-b0284bfb1db5f71778f123754f2eab362b198993.zip | |
Create FKs properly when attaching table as partition
Commit f56f8f8da6af added some code in CloneFkReferencing that's way too
lax about a Constraint node it manufactures, not initializing enough
struct members -- initially_valid in particular was forgotten. This
causes some FKs in partitions added by ALTER TABLE ATTACH PARTITION to
be marked as not validated. Set initially_valid true, which fixes the
bug.
While at it, make the struct initialization more complete. Very similar
code was added in two other places by the same commit; make them all
follow the same pattern for consistency, though no bugs are apparent
there.
This bug has never been reported: I only happened to notice while
working on commit 614a406b4ff1. The test case that was added there with
the improper result is repaired.
Backpatch to 12.
Discussion: https://postgr.es/m/20221005105523.bhuhkdx4olajboof@alvherre.pgsql
Diffstat (limited to 'src/backend/commands/dbcommands.c')
0 files changed, 0 insertions, 0 deletions