diff options
| author | Thomas Munro <tmunro@postgresql.org> | 2019-04-04 21:56:03 +1300 |
|---|---|---|
| committer | Thomas Munro <tmunro@postgresql.org> | 2019-04-04 23:38:38 +1300 |
| commit | 3eb77eba5a51780d5cf52cd66a9844cd4d26feb0 (patch) | |
| tree | 8602d49072771b9c6c21c642110844b5f5c87939 /src/backend/commands/dbcommands.c | |
| parent | 33215d113d61980a4b2f2aec36cdcd21fa58c1c4 (diff) | |
| download | postgresql-3eb77eba5a51780d5cf52cd66a9844cd4d26feb0.tar.gz postgresql-3eb77eba5a51780d5cf52cd66a9844cd4d26feb0.zip | |
Refactor the fsync queue for wider use.
Previously, md.c and checkpointer.c were tightly integrated so that
fsync calls could be handed off and processed in the background.
Introduce a system of callbacks and file tags, so that other modules
can hand off fsync work in the same way.
For now only md.c uses the new interface, but other users are being
proposed. Since there may be use cases that are not strictly SMGR
implementations, use a new function table for sync handlers rather
than extending the traditional SMGR one.
Instead of using a bitmapset of segment numbers for each RelFileNode
in the checkpointer's hash table, make the segment number part of the
key. This requires sending explicit "forget" requests for every
segment individually when relations are dropped, but suits the file
layout schemes of proposed future users better (ie sparse or high
segment numbers).
Author: Shawn Debnath and Thomas Munro
Reviewed-by: Thomas Munro, Andres Freund
Discussion: https://postgr.es/m/CAEepm=2gTANm=e3ARnJT=n0h8hf88wqmaZxk0JYkxw+b21fNrw@mail.gmail.com
Diffstat (limited to 'src/backend/commands/dbcommands.c')
| -rw-r--r-- | src/backend/commands/dbcommands.c | 7 |
1 files changed, 4 insertions, 3 deletions
diff --git a/src/backend/commands/dbcommands.c b/src/backend/commands/dbcommands.c index 35cad0b6294..9707afabd98 100644 --- a/src/backend/commands/dbcommands.c +++ b/src/backend/commands/dbcommands.c @@ -54,6 +54,7 @@ #include "storage/fd.h" #include "storage/lmgr.h" #include "storage/ipc.h" +#include "storage/md.h" #include "storage/procarray.h" #include "storage/smgr.h" #include "utils/acl.h" @@ -941,11 +942,11 @@ dropdb(const char *dbname, bool missing_ok) * worse, it will delete files that belong to a newly created database * with the same OID. */ - ForgetDatabaseFsyncRequests(db_id); + ForgetDatabaseSyncRequests(db_id); /* * Force a checkpoint to make sure the checkpointer has received the - * message sent by ForgetDatabaseFsyncRequests. On Windows, this also + * message sent by ForgetDatabaseSyncRequests. On Windows, this also * ensures that background procs don't hold any open files, which would * cause rmdir() to fail. */ @@ -2150,7 +2151,7 @@ dbase_redo(XLogReaderState *record) DropDatabaseBuffers(xlrec->db_id); /* Also, clean out any fsync requests that might be pending in md.c */ - ForgetDatabaseFsyncRequests(xlrec->db_id); + ForgetDatabaseSyncRequests(xlrec->db_id); /* Clean out the xlog relcache too */ XLogDropDatabase(xlrec->db_id); |