diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2008-11-30 20:51:25 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2008-11-30 20:51:25 +0000 |
| commit | c1f3073333d01987ac9c3e5f6c197b9e2afc3ba9 (patch) | |
| tree | b70ddff5404c442ec13a5c182346984d4300f6da /src/backend/commands/copy.c | |
| parent | 3f936aacc057e4b391ab953fea2ffb689a12a8bc (diff) | |
| download | postgresql-c1f3073333d01987ac9c3e5f6c197b9e2afc3ba9.tar.gz postgresql-c1f3073333d01987ac9c3e5f6c197b9e2afc3ba9.zip | |
Clean up the API for DestReceiver objects by eliminating the assumption
that a Portal is a useful and sufficient additional argument for
CreateDestReceiver --- it just isn't, in most cases. Instead formalize
the approach of passing any needed parameters to the receiver separately.
One unexpected benefit of this change is that we can declare typedef Portal
in a less surprising location.
This patch is just code rearrangement and doesn't change any functionality.
I'll tackle the HOLD-cursor-vs-toast problem in a follow-on patch.
Diffstat (limited to 'src/backend/commands/copy.c')
| -rw-r--r-- | src/backend/commands/copy.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/src/backend/commands/copy.c b/src/backend/commands/copy.c index 2c680008a7a..5c4d06812ac 100644 --- a/src/backend/commands/copy.c +++ b/src/backend/commands/copy.c @@ -8,7 +8,7 @@ * * * IDENTIFICATION - * $PostgreSQL: pgsql/src/backend/commands/copy.c,v 1.301 2008/11/06 20:51:14 tgl Exp $ + * $PostgreSQL: pgsql/src/backend/commands/copy.c,v 1.302 2008/11/30 20:51:25 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -1050,7 +1050,7 @@ DoCopy(const CopyStmt *stmt, const char *queryString) PushUpdatedSnapshot(GetActiveSnapshot()); /* Create dest receiver for COPY OUT */ - dest = CreateDestReceiver(DestCopyOut, NULL); + dest = CreateDestReceiver(DestCopyOut); ((DR_copy *) dest)->cstate = cstate; /* Create a QueryDesc requesting no output */ |