diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2003-08-11 20:46:47 +0000 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2003-08-11 20:46:47 +0000 |
| commit | 88381ade63de931c84f53dc873c986d40b8c8b61 (patch) | |
| tree | 1ec3c77e29b1d320718b64b38db10f8a8f0e0cd3 /src/backend/commands/comment.c | |
| parent | cae912d05bfb354d81427c6ae5354eab90869fe9 (diff) | |
| download | postgresql-88381ade63de931c84f53dc873c986d40b8c8b61.tar.gz postgresql-88381ade63de931c84f53dc873c986d40b8c8b61.zip | |
Code cleanup inspired by recent resname bug report (doesn't fix the bug
yet, though). Avoid using nth() to fetch tlist entries; provide a
common routine get_tle_by_resno() to search a tlist for a particular
resno. This replaces a couple uses of nth() and a dozen hand-coded
search loops. Also, replace a few uses of nth(length-1, list) with
llast().
Diffstat (limited to 'src/backend/commands/comment.c')
| -rw-r--r-- | src/backend/commands/comment.c | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/src/backend/commands/comment.c b/src/backend/commands/comment.c index 4ed3614506d..df09337d720 100644 --- a/src/backend/commands/comment.c +++ b/src/backend/commands/comment.c @@ -7,7 +7,7 @@ * Copyright (c) 1996-2003, PostgreSQL Global Development Group * * IDENTIFICATION - * $Header: /cvsroot/pgsql/src/backend/commands/comment.c,v 1.69 2003/08/04 23:59:37 tgl Exp $ + * $Header: /cvsroot/pgsql/src/backend/commands/comment.c,v 1.70 2003/08/11 20:46:46 tgl Exp $ * *------------------------------------------------------------------------- */ @@ -365,7 +365,7 @@ CommentAttribute(List *qualname, char *comment) if (nnames < 2) /* parser messed up */ elog(ERROR, "must specify relation and attribute"); relname = ltruncate(nnames - 1, listCopy(qualname)); - attrname = strVal(nth(nnames - 1, qualname)); + attrname = strVal(llast(qualname)); /* Open the containing relation to ensure it won't go away meanwhile */ rel = makeRangeVarFromNameList(relname); @@ -583,7 +583,7 @@ CommentRule(List *qualname, char *comment) /* New-style: rule and relname both provided */ Assert(nnames >= 2); relname = ltruncate(nnames - 1, listCopy(qualname)); - rulename = strVal(nth(nnames - 1, qualname)); + rulename = strVal(llast(qualname)); /* Open the owning relation to ensure it won't go away meanwhile */ rel = makeRangeVarFromNameList(relname); @@ -778,7 +778,7 @@ CommentTrigger(List *qualname, char *comment) if (nnames < 2) /* parser messed up */ elog(ERROR, "must specify relation and trigger"); relname = ltruncate(nnames - 1, listCopy(qualname)); - trigname = strVal(nth(nnames - 1, qualname)); + trigname = strVal(llast(qualname)); /* Open the owning relation to ensure it won't go away meanwhile */ rel = makeRangeVarFromNameList(relname); @@ -856,7 +856,7 @@ CommentConstraint(List *qualname, char *comment) if (nnames < 2) /* parser messed up */ elog(ERROR, "must specify relation and constraint"); relName = ltruncate(nnames - 1, listCopy(qualname)); - conName = strVal(nth(nnames - 1, qualname)); + conName = strVal(llast(qualname)); /* Open the owning relation to ensure it won't go away meanwhile */ rel = makeRangeVarFromNameList(relName); |