aboutsummaryrefslogtreecommitdiff
path: root/src/backend/access/transam/xlog.c
diff options
context:
space:
mode:
authorMichael Paquier <michael@paquier.xyz>2022-09-27 09:15:07 +0900
committerMichael Paquier <michael@paquier.xyz>2022-09-27 09:15:07 +0900
commite1e6f8f3dfe141839220875270a81ad3a719e0b6 (patch)
treed3bed4b143fa09b7499bf5e1eb3fa150b7ceca00 /src/backend/access/transam/xlog.c
parent31d2c4716e6b429353bb81cebaa0f2b1267823d6 (diff)
downloadpostgresql-e1e6f8f3dfe141839220875270a81ad3a719e0b6.tar.gz
postgresql-e1e6f8f3dfe141839220875270a81ad3a719e0b6.zip
Remove dependency to StringInfo in xlogbackup.{c.h}
This was used as the returned result type of the generated contents for the backup_label and backup history files. This is replaced by a simple string, reducing the cleanup burden of all the callers of build_backup_content(). Reviewed-by: Bharath Rupireddy Discussion: https://postgr.es/m/YzERvNPaZivHEKZJ@paquier.xyz
Diffstat (limited to 'src/backend/access/transam/xlog.c')
-rw-r--r--src/backend/access/transam/xlog.c5
1 files changed, 2 insertions, 3 deletions
diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index 7606ee128a9..1dd6df0fe15 100644
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -8711,7 +8711,7 @@ do_pg_backup_stop(BackupState *state, bool waitforarchive)
}
else
{
- StringInfo history_file;
+ char *history_file;
/*
* Write the backup-end xlog record
@@ -8751,8 +8751,7 @@ do_pg_backup_stop(BackupState *state, bool waitforarchive)
/* Build and save the contents of the backup history file */
history_file = build_backup_content(state, true);
- fprintf(fp, "%s", history_file->data);
- pfree(history_file->data);
+ fprintf(fp, "%s", history_file);
pfree(history_file);
if (fflush(fp) || ferror(fp) || FreeFile(fp))