diff options
| author | Andres Freund <andres@anarazel.de> | 2016-03-27 17:17:00 +0200 |
|---|---|---|
| committer | Andres Freund <andres@anarazel.de> | 2016-03-27 18:10:19 +0200 |
| commit | 1a7a43672bf2939dda93a27d498349e7a4aa3c14 (patch) | |
| tree | 7c2b58901af052b421fa1114d4c899c4b870163c /src/backend/access/transam/xact.c | |
| parent | af4472bcb88ab36b9abbe7fd5858e570a65a2d1a (diff) | |
| download | postgresql-1a7a43672bf2939dda93a27d498349e7a4aa3c14.tar.gz postgresql-1a7a43672bf2939dda93a27d498349e7a4aa3c14.zip | |
Don't use !! but != 0/NULL to force boolean evaluation.
I introduced several uses of !! to force bit arithmetic to be boolean,
but per discussion the project prefers != 0/NULL.
Discussion: CA+TgmoZP5KakLGP6B4vUjgMBUW0woq_dJYi0paOz-My0Hwt_vQ@mail.gmail.com
Diffstat (limited to 'src/backend/access/transam/xact.c')
| -rw-r--r-- | src/backend/access/transam/xact.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/access/transam/xact.c b/src/backend/access/transam/xact.c index 89a14b4cbe4..e31540548e0 100644 --- a/src/backend/access/transam/xact.c +++ b/src/backend/access/transam/xact.c @@ -5335,7 +5335,8 @@ xact_redo_commit(xl_xact_parsed_commit *parsed, LWLockRelease(XidGenLock); } - Assert(!!(parsed->xinfo & XACT_XINFO_HAS_ORIGIN) == (origin_id != InvalidRepOriginId)); + Assert(((parsed->xinfo & XACT_XINFO_HAS_ORIGIN) == 0) == + (origin_id == InvalidRepOriginId)); if (parsed->xinfo & XACT_XINFO_HAS_ORIGIN) commit_time = parsed->origin_timestamp; |