diff options
| author | Robert Haas <rhaas@postgresql.org> | 2022-02-08 15:52:40 -0500 |
|---|---|---|
| committer | Robert Haas <rhaas@postgresql.org> | 2022-02-08 15:53:19 -0500 |
| commit | aa64f23b02924724eafbd9eadbf26d85df30a12b (patch) | |
| tree | 54f72bfd7e36c2e879dc87149eb94db220d1cae3 /src/backend/access/transam/twophase.c | |
| parent | 2da896182ce11240774af6c4d769777f90a09536 (diff) | |
| download | postgresql-aa64f23b02924724eafbd9eadbf26d85df30a12b.tar.gz postgresql-aa64f23b02924724eafbd9eadbf26d85df30a12b.zip | |
Remove MaxBackends variable in favor of GetMaxBackends() function.
Previously, it was really easy to write code that accessed MaxBackends
before we'd actually initialized it, especially when coding up an
extension. To make this less error-prune, introduce a new function
GetMaxBackends() which should be used to obtain the correct value.
This will ERROR if called too early. Demote the global variable to
a file-level static, so that nobody can peak at it directly.
Nathan Bossart. Idea by Andres Freund. Review by Greg Sabino Mullane,
by Michael Paquier (who had doubts about the approach), and by me.
Discussion: http://postgr.es/m/20210802224204.bckcikl45uezv5e4@alap3.anarazel.de
Diffstat (limited to 'src/backend/access/transam/twophase.c')
| -rw-r--r-- | src/backend/access/transam/twophase.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c index 271a3146dbb..608c5149e52 100644 --- a/src/backend/access/transam/twophase.c +++ b/src/backend/access/transam/twophase.c @@ -260,6 +260,7 @@ TwoPhaseShmemInit(void) { GlobalTransaction gxacts; int i; + int max_backends = GetMaxBackends(); Assert(!found); TwoPhaseState->freeGXacts = NULL; @@ -293,7 +294,7 @@ TwoPhaseShmemInit(void) * prepared transaction. Currently multixact.c uses that * technique. */ - gxacts[i].dummyBackendId = MaxBackends + 1 + i; + gxacts[i].dummyBackendId = max_backends + 1 + i; } } else |