diff options
author | Tom Lane <tgl@sss.pgh.pa.us> | 2016-05-07 16:36:50 -0400 |
---|---|---|
committer | Tom Lane <tgl@sss.pgh.pa.us> | 2016-05-07 16:36:50 -0400 |
commit | b8180884082d46346394e1c54fc454d2c16bf3ee (patch) | |
tree | d4f660d05b5916f639d70b8ebd2cfc9dc67cead9 /src/backend/access/transam/commit_ts.c | |
parent | 691d99de386aa1f5a858e04634dbaaba48488ef8 (diff) | |
download | postgresql-b8180884082d46346394e1c54fc454d2c16bf3ee.tar.gz postgresql-b8180884082d46346394e1c54fc454d2c16bf3ee.zip |
In new pg_dump TAP tests, remove trailing "$" from regexps using /m.
It emerges that some Perl versions before 5.8.9 have a bug with regexps
that use the /m flag and contain "$". This is the reason why jacana
is still failing on HEAD, and I was able to duplicate the failure on
prairiedog's host. There's no real need for "$" in these patterns,
since they are already matching through the statement-terminating
semicolons (or matching an explicit \n in some cases). So just
remove it.
Note: the reason jacana hasn't actually reported any failures in the
last little while is that the way the pg_dump TAP tests are set up, any
failure of this sort results in echoing the entire pg_dump dump output
to stderr. Since there were about a hundred such failures, that resulted
in a 30MB log file which choked the buildfarm upload script. There is
room for improvement here :-(.
Per off-list discussion with Andrew and Stephen.
Diffstat (limited to 'src/backend/access/transam/commit_ts.c')
0 files changed, 0 insertions, 0 deletions