diff options
| author | Tom Lane <tgl@sss.pgh.pa.us> | 2023-11-28 13:32:15 -0500 |
|---|---|---|
| committer | Tom Lane <tgl@sss.pgh.pa.us> | 2023-11-28 13:32:15 -0500 |
| commit | a916b47e23290ca24ffd083e5128d994f62966f6 (patch) | |
| tree | 87962cf3b3ff2d1db34b8005e79513bc0cc9ef94 /src/backend/access/transam/commit_ts.c | |
| parent | c82207a548db47623a2bfa2447babdaa630302b9 (diff) | |
| download | postgresql-a916b47e23290ca24ffd083e5128d994f62966f6.tar.gz postgresql-a916b47e23290ca24ffd083e5128d994f62966f6.zip | |
Clean up usage of bison precedence for non-operator keywords.
Assigning a precedence to a keyword that isn't a kind of expression
operator is rather dangerous, because it might mask grammar
ambiguities that we'd rather know about. It's much safer to attach
explicit precedences to individual rules, which will affect the
behavior of only that one rule. Moreover, when we do have to give
a precedence to a non-operator keyword, we should try to give it the
same precedence as IDENT, thereby reducing the risk of surprising
side-effects.
Apply this hard-won knowledge to SET (which I misassigned ages ago
in commit 2647ad658) and some SQL/JSON-related productions
(from commits 6ee30209a, 71bfd1543).
Patch HEAD only, since there's no evidence of actual bugs here.
Discussion: https://postgr.es/m/CADT4RqBPdbsZW7HS1jJP319TMRHs1hzUiP=iRJYR6UqgHCrgNQ@mail.gmail.com
Diffstat (limited to 'src/backend/access/transam/commit_ts.c')
0 files changed, 0 insertions, 0 deletions