diff options
| author | Alexander Korotkov <akorotkov@postgresql.org> | 2024-03-30 22:39:03 +0200 |
|---|---|---|
| committer | Alexander Korotkov <akorotkov@postgresql.org> | 2024-03-30 22:53:56 +0200 |
| commit | b1484a3f1910bfd0e254afe40085dfc3351bda8c (patch) | |
| tree | 329e9e84dba07d2b85487c4acb5ebb975836947b /src/backend/access/heap/heapam_handler.c | |
| parent | c95c25f9af4bc77f2f66a587735c50da08c12b37 (diff) | |
| download | postgresql-b1484a3f1910bfd0e254afe40085dfc3351bda8c.tar.gz postgresql-b1484a3f1910bfd0e254afe40085dfc3351bda8c.zip | |
Let table AM insertion methods control index insertion
Previously, the executor did index insert unconditionally after calling
table AM interface methods tuple_insert() and multi_insert(). This commit
introduces the new parameter insert_indexes for these two methods. Setting
'*insert_indexes' to true saves the current logic. Setting it to false
indicates that table AM cares about index inserts itself and doesn't want the
caller to do that.
Discussion: https://postgr.es/m/CAPpHfdurb9ycV8udYqM%3Do0sPS66PJ4RCBM1g-bBpvzUfogY0EA%40mail.gmail.com
Reviewed-by: Pavel Borisov, Matthias van de Meent, Mark Dilger
Diffstat (limited to 'src/backend/access/heap/heapam_handler.c')
| -rw-r--r-- | src/backend/access/heap/heapam_handler.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/src/backend/access/heap/heapam_handler.c b/src/backend/access/heap/heapam_handler.c index 26b3be9779d..41a4bb0981d 100644 --- a/src/backend/access/heap/heapam_handler.c +++ b/src/backend/access/heap/heapam_handler.c @@ -245,7 +245,7 @@ heapam_tuple_satisfies_snapshot(Relation rel, TupleTableSlot *slot, static TupleTableSlot * heapam_tuple_insert(Relation relation, TupleTableSlot *slot, CommandId cid, - int options, BulkInsertState bistate) + int options, BulkInsertState bistate, bool *insert_indexes) { bool shouldFree = true; HeapTuple tuple = ExecFetchSlotHeapTuple(slot, true, &shouldFree); @@ -261,6 +261,8 @@ heapam_tuple_insert(Relation relation, TupleTableSlot *slot, CommandId cid, if (shouldFree) pfree(tuple); + *insert_indexes = true; + return slot; } |